Repository navigation
fix(tracer): support converting OpenTelemetry parent span context - #904
Merged
Merged
Conversation
pvital
requested changes
Sep 17, 2026
pvital
left a comment
pvital
left a comment
Member
There was a problem hiding this comment.
@arjun-rajappa, can you add specific start_span test cases with context arguments with OTel and Instana SpanContext? You can use the Pytest parametrization for that.
CagriYonca
requested changes
Sep 30, 2026
Member
|
@arjun-rajappa could you rebase and check @CagriYonca requests, please? |
Allow OpenTelemetry SpanContext instances in start_span by converting valid non-Instana parent contexts into Instana SpanContext objects instead of raising a TypeError. If the context is invalid, fall back to None. Include debug logs for parent context conversion and invalid context resets. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
… Context Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
pvital
force-pushed
the
fix/support-otel-parent-span-context
branch
from
October 13, 2026 11:15
a57b79e to
93cd60d
Compare
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Convert 128-bit OpenTelemetry parent trace IDs to 64-bit integers while preserving the full 32-character hex ID in long_trace_id, and default trace_parent to None. Update parametrized test cases to cover both 128-bit and 64-bit parent contexts. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
CagriYonca
approved these changes
Oct 13, 2026
CagriYonca
left a comment
CagriYonca
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks Arjun!
CagriYonca
added a commit
that referenced
this pull request
Oct 15, 2026
…xt (issue #879) Add test_w3c_traceparent_upstream_context to verify that FastAPI >= 0.142.0 correctly handles incoming W3C traceparent headers without raising TypeError. - Sends a real traceparent header via TestClient - Asserts HTTP 200 (not 500) - Verifies upstream trace_id (lower 64-bit) and span_id are preserved in the ASGI span - Checks X-INSTANA-T, X-INSTANA-S, Server-Timing response headers are present Ref: #879 PR: #904 Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
added a commit
that referenced
this pull request
Oct 15, 2026
…xt (issue #879) Add test_w3c_traceparent_upstream_context to verify that FastAPI >= 0.142.0 correctly handles incoming W3C traceparent headers without raising TypeError. - Sends a real traceparent header via TestClient - Asserts HTTP 200 (not 500) - Verifies upstream trace_id (lower 64-bit) and span_id are preserved in the ASGI span - Checks X-INSTANA-T, X-INSTANA-S, Server-Timing response headers are present Ref: #879 PR: #904 Signed-off-by: Cagri Yonca <cagri@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow OpenTelemetry SpanContext instances in start_span by converting valid non-Instana parent contexts into Instana SpanContext objects instead of raising a TypeError. If the context is invalid, fall back to None. Include debug logs for parent context conversion and invalid context resets.