Updates rust version to 1.94#1527
Open
simongdavies wants to merge 7 commits into
Open
Conversation
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
the
kind/dependencies
simongdavies
requested review from
andreiltd,
jprendes,
jsturtevant,
ludfjig,
squillace and
syntactically
as code owners
Copilot stopped reviewing on behalf of
simongdavies due to an error
June 11, 2026 14:47
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the repository’s Rust toolchain/MSRV and aligns CI/dev tooling with the new version, plus a couple of small Rust/clippy cleanups.
Changes:
- Bump Rust toolchain from 1.89 to 1.94 across
rust-toolchain.toml, GitHub Actions workflows, and devcontainer config - Update Nix flake pinned stable toolchain snapshot (date/sha256)
- Minor Rust code style/lint adjustments (clippy allowances,
is_multiple_of)
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hyperlight_guest_tracing/src/invariant_tsc.rs | Adds clippy/MSRV-related comment + #[allow(unused_unsafe)] around __cpuid usage |
| src/hyperlight_common/src/virtq/ring.rs | Replaces odd-wrap check with is_multiple_of(2) |
| src/hyperlight_common/src/virtq/mod.rs | Adds clippy allow for panic in const layout verification |
| rust-toolchain.toml | Bumps pinned toolchain channel to 1.94 |
| flake.nix | Updates stable toolchain snapshot date and sha256 |
| .github/workflows/dep_update_guest_locks.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_run_examples.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_fuzzing.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_code_checks.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_build_test.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_build_guests.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/dep_benchmarks.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/copilot-setup-steps.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/RustNightly.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/PrimeCaches.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/CreateRelease.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/CreateDevcontainerImage.yml | Updates default toolchain env to 1.94 |
| .github/workflows/Coverage.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/CargoPublish.yml | Updates CI rust-toolchain to 1.94 |
| .github/workflows/CargoAudit.yml | Updates audit toolchain to 1.94 |
| .devcontainer/Dockerfile | Updates devcontainer Rust toolchain arg to 1.94 |
On Rust 1.94+, function-to-integer casts require an intermediate pointer cast. Cast via 'as *const () as usize' to comply with the function_casts_as_integer lint while maintaining compatibility with Rust 1.89. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
- Remove src/hyperlight_guest_bin/third_party/picolibc from index (accidentally committed as nested git repo, breaking submodule init in CI) - Pin cargo-hyperlight to v0.1.11 in Justfile (latest stable, validated with Rust 1.94+) - Update CI workflows (RustNightly.yml, CreateRelease.yml) to use 'just ensure-cargo-hyperlight' recipe instead of inline install commands (single source of truth) - Fix simpleguest rustfmt formatting per nightly-2026-02-27 Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
ludfjig
reviewed
Jun 11, 2026
Comment on lines
50
to
+54
| ensure-cargo-hyperlight: | ||
| cargo install --locked cargo-hyperlight | ||
| # Force reinstall so self-hosted runners don't keep a preinstalled binary with the same semver. | ||
| cargo install --locked --version 0.1.11 --force cargo-hyperlight | ||
| cargo hyperlight --version | ||
| {{ if os() == "windows" { "Get-Command cargo-hyperlight" } else { "command -v cargo-hyperlight" } }} |
Contributor
There was a problem hiding this comment.
This is ran as part of just guest, which will now reinstall cargo-hyperlight evertime which seems wrong
Member
Author
There was a problem hiding this comment.
I dont know what went wrong with the runners but this was the fix, I'll look at it some more
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates rust version to 1.94 , MSRV remains at 1.89.
Latest rust version is 1.96 but this requires a change to cargo-hyperlight. I will open a PR for that shortly along with a PR to update the common-workflow and dev-images