Skip to content

Fix: size the ring task window for host_build_graph PA Case1/Case2 - #2164

Open
noabauma wants to merge 1 commit into
hw-native-sys:mainfrom
huawei-csl:hbg-pa-ring-window
Open

Fix: size the ring task window for host_build_graph PA Case1/Case2#2164
noabauma wants to merge 1 commit into
hw-native-sys:mainfrom
huawei-csl:hbg-pa-ring-window

Conversation

@noabauma

@noabauma noabauma commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Both cases are whole-graph-resident and build more tasks than the 16384-task default window, so bind fails with -1000 before any kernel runs. Case1 orchestrates ~65,792 tasks and Case2 ~32,832; each case now requests the next power of two above its own count via CallConfig.runtime_env.ring_task_window.

Only the task window needs a knob -- the graph heap is committed to its measured size after orchestration and takes no configuration.

Both cases are whole-graph-resident and build more tasks than the
16384-task default window, so bind fails with -1000 before any kernel
runs. Case1 orchestrates ~65,792 tasks and Case2 ~32,832; each case now
requests the next power of two above its own count via
CallConfig.runtime_env.ring_task_window.

Only the task window needs a knob -- the graph heap is committed to its
measured size after orchestration and takes no configuration.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4b885383-8305-4ec0-85f6-9aca3ccc4154

📥 Commits

Reviewing files that changed from the base of the PR and between 7bcdc95 and d9e1aa9.

📒 Files selected for processing (1)
  • tests/st/a2a3/host_build_graph/paged_attention/test_paged_attention.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Two paged-attention host build graph test cases now set explicit runtime_env.ring_task_window values and document their resident task counts.

Changes

Paged attention task window configuration

Layer / File(s) Summary
Configure resident task windows
tests/st/a2a3/host_build_graph/paged_attention/test_paged_attention.py
Case1 sets ring_task_window to 131072. Case2 sets it to 65536. Comments document the resident task counts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d9e1a

The paged-attention host build graph cases now request sufficiently sized task windows, preventing pre-kernel bind failures for their resident task graphs. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change: sizing the ring task window for host_build_graph paged-attention Case1 and Case2.
Description check ✅ Passed The description explains the task counts, the default-window failure, and the configured remediation. It directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Some tools did not complete. Review the errors below.

🔧 Ruff (0.16.3)
tests/st/a2a3/host_build_graph/paged_attention/test_paged_attention.py

�[1;31mruff failed�[0m
�[1mCause:�[0m Required version ==0.14.8 does not match the running version 0.16.3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit tunes the task table bright
Ring windows fit the graphs just right
Case One holds tasks in a spacious span
Case Two follows with a smaller plan
The paged paths hop with care
And resident tasks find room there

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant