feat(squads): pivot squad_members + SquadRole + recorder de eventos (#355)#407
Closed
sirelves wants to merge 1 commit into
Closed
feat(squads): pivot squad_members + SquadRole + recorder de eventos (#355)#407sirelves wants to merge 1 commit into
sirelves wants to merge 1 commit into
Conversation
…ts (#355) - squad_members pivot (SquadMember) + SquadRole enum - squad_membership_events append-only trail (SquadMembershipEvent, immutable) + MembershipAction enum - RecordMembershipEvent recorder, reused by every membership/role mutation - factories + recorder and immutability tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent
#342 · Closes #355 · Desbloqueada por #354 (merged)
O que construir
Pivot de membros, papéis in-squad e o recorder da trilha append-only de eventos de membership — módulo profundo reusado por todas as mutações (S3/S6/S8/S9/S10).
O que este PR entrega
Migrations (via
artisan make:migration --module=squads, datasTz, jsonb)squad_members—iduuid, FKstenant_id/squad_id/user_id,role,joined_at,left_at?,UNIQUE (squad_id, user_id)squad_membership_events(append-only) —actor_id?(nullOnDelete = sistema),action,from_role?/to_role?,reason?,metadata jsonb?,occurred_at; índices(squad_id, occurred_at)e(user_id, occurred_at)Enums —
SquadRole(captain/sub_captain/member/ex_member),MembershipAction(join/leave/promote/demote)Models —
SquadMember(Pivot +HasUuids) eSquadMembershipEvent, com PHPDoc@propertysincronizado,#[Table],#[UseFactory]e casts de enum/data. O evento é imutável no próprio model (booted()barra update/delete viaMembershipEventIsImmutable), garantindo o append-only.Recorder —
RecordMembershipEvent(Action): grava um evento por mutação,actornulo = sistema,occurredAtdefaultnow(),tenant_idderivado do squad.Factories + Tests —
SquadMemberFactory,SquadMembershipEventFactory, e testes do recorder (transição completa, evento de sistema, metadata jsonb) + imutabilidade (update e delete).Critérios de aceite
Tz, jsonb)SquadRoleeMembershipActionaction,from_role/to_role,actor_id,occurred_atDecisões de escopo (worth a look)
UNIQUE (squad_id) WHERE role='captain'e a exclusividadeUNIQUE (tenant_id, user_id) WHERE role IN (...)emsquad_members. O feat(squads): pivot squad_members + SquadRole + recorder de eventos #355 pede sóUNIQUE (squad_id, user_id), então não incluí os parciais aqui — eles pertencem às issues de join/exclusividade/liderança que introduzem as Actions que mantêm essas invariantes. Fácil de adicionar agora se preferirem cravar na criação da tabela.metadatacast'array'seguindo o precedente do repo (activity/MembershipEvente outros); não há gateNoLooseArrayCastsnesta linha.Testes
pest app-modules/squads→ 21 passed / 48 assertionspint✅ ·phpstan(src) ✅ ·rector✅4.x(chore: sync conventions, tooling, and tests #402): rector named-args = 0 mudanças no módulo. O syncfeat/squads ← 4.xfica como PR separado (padrão chore(squads): sync 4.x into feat/squads #404); este PR traz só o feat(squads): pivot squad_members + SquadRole + recorder de eventos #355.BDD