Repository navigation
Conversation
Lysxia
force-pushed
the
exception-getContents
branch
from
October 25, 2026 21:07
104176c to
f346371
Compare
Lysxia
force-pushed
the
exception-getContents
branch
from
October 25, 2026 21:15
f346371 to
bdec0dd
Compare
Bodigrim
reviewed
Oct 26, 2026
| hClose h0 | ||
|
|
||
| -- readFile must close the handle on exception | ||
| let checkReadFile rf = do |
Contributor
There was a problem hiding this comment.
Could you please add a type signature for checkReadFile?
Bodigrim
reviewed
Oct 26, 2026
| Left e | Just ioe <- E.fromException e -> E.throwIO (augmentIOError ioe "hGetContents" h) | ||
| Left e -> E.throwIO | ||
| #if __GLASGOW_HASKELL__ >= 912 | ||
| (E.NoBacktrace e) |
Contributor
There was a problem hiding this comment.
Why do we want no backtrace? (I'm rather illiterate when it comes to exceptions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #712