Skip to content

Improper encoding of reserved characters #83

Open

Description

@ttuegel

This was originally reported as a Cabal bug, but I believe it belongs here:

The value of HTTP_PROXY has as format
http://user:pass@host:80/

In the password special characters can occur, like @ and !.
According to wiki (http://en.wikipedia.org/wiki/Percent-escape)
these characters must be percent-encoded, like %40 and %21.

Cabal doesn't accept percent-encoded characters.
And cabal errs on these characters (if password is a@b, Cabal doesn't look to the right site, but >probably to "b@host:80" (error message is not clear enough to be certain)

Activity

  1. hsenag commented on Apr 24, 2015

    @hsenag
    Member

    Sounds plausible - if you can supply a fix that'd be great, otherwise I'll take a look but no guarantees as to when I'm afraid.

    It'd be nice to have a test but I don't see any Haskell HTTP proxies that support authentication around so that's probably not feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions