Host test suite + coverage report (independent)#5
Merged
Conversation
…es, base32 UB fix, own test.yml + pages workflow, lcov/genhtml report Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A fresh clone has empty libs/qrcodegen and libs/littlefs, so `make -C test` failed with a cryptic gcc "qrcodegen.h: No such file" error. Add a check-submodules prerequisite to asan/valgrind/coverage that fails fast telling the user to run `git submodule update --init --recursive`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host test suite (independent)
Base
master, shares zero files with the format/lint PR (#2) — the two can be reviewed and merged in any order.Contents
test/— host harnesses (native Linux ELF) for the hardware-independent logic:harness_secret_qr.c(secret → base32 → otpauth URI → QR, mirroringserial/commands_keys.c) +harness_base64.c(base64 roundtrip).test/Makefiletargetsasan/valgrind/coverage, needing one host stub (test/stub/pico/rand.h)..github/workflows/test.yml— standalone workflow: ASan+UBSan + Valgrind viamake -C test ..., submodules recursive + lcov. No dependency on any other PR..github/workflows/pages.yml— publishes the coverage report to GitHub Pages.libs/base32/base32.c(int→uint32_taccumulator); the harness is the regression test.Coverage report
lcov + genhtml over the modules the harnesses exercise (base32, base64, random): 98.4% lines, 84.8% branches. Live from my fork: https://d33mobile.github.io/hslock/
CI status
masterhas no workflows yet, so GitHub runs nopull_requestchecks here. Green on my fork (test + pages): d33mobile#7Recreated from scratch with fresh commits (the previous #4 looked corrupted after a GitHub downtime).
🤖 Generated with Claude Code