feat(compute): update discovery doc to 20260807 and generate new services - #16356
feat(compute): update discovery doc to 20260807 and generate new services#16356colinmoy wants to merge 2 commits into
Conversation
product-auto-label
Bot
added
the
api: compute
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the Google Cloud C++ SDK, including the addition of new services (advice, cross_site_networks, global_vm_extension_policies) and the expansion of existing ones (addresses, autoscalers, backend_buckets, backend_services, disks, firewalls, forwarding_rules, global_addresses, global_operations, global_public_delegated_prefixes, health_checks). The changes include updating generated code, adding new client and connection classes, and updating proto exports. The review comment regarding the hardcoded path in the update_discovery_doc.sh script is valid and provides an actionable improvement for script robustness.
610534e to
6b9c4da
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16356 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 2227 2227
Lines 209614 209626 +12
=======================================
+ Hits 193351 193373 +22
+ Misses 16263 16253 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| done | ||
|
|
||
| io::log_yellow "Adding new directories to ${COMPUTE_SERVICE_DIRS_BZL_RELATIVE_PATH}" | ||
| rm -rf ./cmake-build-debug |
There was a problem hiding this comment.
We should probably move away from a fixed directory, let's try something like:
CMAKE_BUILD_DIR=$(mktemp -d)
cmake -DGOOGLE_CLOUD_CPP_ENABLE=compute -S . -B ${CMAKE_BUILD_DIR}
Any created directories will get cleaned up periodically.
| a\ "${service_dir}" | ||
| } | ||
| EOT | ||
| sed -i -f - "${PROJECT_ROOT}/${COMPUTE_SERVICE_DIRS_BZL_RELATIVE_PATH}" <<EOT |
There was a problem hiding this comment.
I'm surprised we need to update this manually. Our CMakeLists.txt files are intended to generate the necessary .bzl files for bazel builds. If this is not happening, we should look into the cmake files and address is there.
| rm -rf ./cmake-build-debug | ||
| cmake -DGOOGLE_CLOUD_CPP_ENABLE=compute -S . -B ./cmake-build-debug | ||
| python3 -c ' | ||
| with open("google/cloud/compute/service_dirs.bzl", "r") as f: |
There was a problem hiding this comment.
Let's not inject python into this bash script.
Per my previous comment, this cmake configure step should generate both the necessary cmake and .bzl files.
| // log, and cannot affect the output of the index.html file. | ||
| static auto const kSkippedStatus = std::unordered_set<std::string>{ | ||
| "STATUS_UNKNOWN", "QUEUED", "WORKING", | ||
| "STATUS_UNKNOWN", |
There was a problem hiding this comment.
Given the formatting changes here and in other non-compute directories, you may need to run checkers-pr one more time.
| /// another. | ||
| /// *Note*: Moving VMs or disks by using this method might | ||
| /// cause unexpected behavior. For more information, see the [known | ||
| /// | ||
| /// issue](/compute/docs/troubleshooting/known-issues#moving_vms_or_disks_using_the_moveinstance_api_or_the_causes_unexpected_behavior). |
There was a problem hiding this comment.
This markdown link is what's likely causing the docs build to fail. We should look at detecting these relative links
/compute/docs/troubleshooting/known-issues#moving_vms_or_disks_using_the_moveinstance_api_or_the_causes_unexpected_behaviior
and expanding them to proper URLs
https://cloud.google.com/compute/docs/troubleshooting/known-issues#moving_vms_or_disks_using_the_moveinstance_api_or_the_causes_unexpected_behaviior
eea2344 to
079ebd4
Compare
079ebd4 to
8787f6c
Compare
2 participants
No description provided.