Repository navigation
Conversation
After a refused nonblocking connect, applications can read ECONNREFUSED from SO_ERROR and poll again. Linux reports a hangup. gVisor also reported POLLERR because a terminal TCP socket claimed every requested event, including urgent data. Report the normal terminal events and check the pending hard error or extended error queue before reporting POLLERR, as tcp_poll does [1]. Protect both socket errors with their own mutex so poll can inspect the hard error without acquiring the endpoint lock. Updates google#6666 [1]: https://github.com/torvalds/linux/blob/adc218676/net/ipv4/tcp.c#L608-L611
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a refused nonblocking connect, applications can read ECONNREFUSED
from SO_ERROR and poll again. Linux reports a hangup. gVisor also
reported POLLERR because a terminal TCP socket claimed every requested
event, including urgent data.
Report the normal terminal events and check the pending hard error or
extended error queue before reporting POLLERR, as tcp_poll does 1.
Protect both socket errors with their own mutex so poll can inspect the
hard error without acquiring the endpoint lock.
Updates #6666