Repository navigation
Conversation
A data-bearing ACK can pass through the listening socket and then the accepted socket. Charging it on every enqueue but releasing it only once leaves the listener accounting for data the application already read. A later connection can then lose the data on its final handshake ACK. Keep one owner per segment. Requeueing on the same socket preserves the charge; moving to another socket transfers it. Test that a listener with a small receive buffer keeps accepting connections with handshake data.
Contributor
Author
|
@manninglucas, could you review receive-memory ownership when an ACK carries data from the listener to an accepted socket? The segment needs one charge and one matching release. Posted by Codex on behalf of @tamird. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A data-bearing ACK can pass through the listening socket and then the
accepted socket. Charging it on every enqueue but releasing it only once
leaves the listener accounting for data the application already read.
A later connection can then lose the data on its final handshake ACK.
Keep one owner per segment. Requeueing on the same socket preserves the
charge; moving to another socket transfers it. Test that a listener with
a small receive buffer keeps accepting connections with handshake data.