Skip to content

Implement PDF reports for submissions#3754

Merged
andreia-ferreira merged 5 commits into
masterfrom
andreia/3739/pdf-report-impl
Jun 25, 2026
Merged

Implement PDF reports for submissions#3754
andreia-ferreira merged 5 commits into
masterfrom
andreia/3739/pdf-report-impl

Conversation

@andreia-ferreira

@andreia-ferreira andreia-ferreira commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Fixes #3715

This PR finalizes the PDF report feature integrating it and adding the entry points in the UI. Changes include:

  • add new getSubmissions method to SubmissionRepository in order to return all local submissions for a given LOI
  • add LoiReportAction to trigger the share/open actions from the composables
  • add LoiReportExporter to use in DataCollectionViewModel and HomeScreenMapContainerViewModel in response of each action. HomeScreenMapContainerViewModel had a small refactor to use the uiEffects pattern as the data collection VM
  • DI infrastructure to wire up the different components
Screen_recording_20260624_092140.webm

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.40206% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.25%. Comparing base (09d0362) to head (77c5f29).

Files with missing lines Patch % Lines
.../ui/datacollection/DataCollectionScreenPreviews.kt 0.00% 17 Missing ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 20.00% 12 Missing ⚠️
...datacollection/DataSubmissionConfirmationScreen.kt 70.96% 8 Missing and 1 partial ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 77.77% 1 Missing and 7 partials ⚠️
...droid/ui/home/mapcontainer/jobs/JobMapComponent.kt 38.46% 2 Missing and 6 partials ⚠️
...id/ui/home/mapcontainer/jobs/ShareLocationModal.kt 52.94% 7 Missing and 1 partial ⚠️
...droid/ui/datacollection/DataCollectionViewModel.kt 40.00% 0 Missing and 3 partials ⚠️
...platform/domain/model/submission/SubmissionData.kt 0.00% 3 Missing ⚠️
.../home/mapcontainer/HomeScreenMapContainerScreen.kt 80.00% 1 Missing ⚠️
...undplatform/domain/usecases/GetLoiReportUseCase.kt 95.23% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3754      +/-   ##
============================================
+ Coverage     66.99%   67.25%   +0.25%     
- Complexity     1778     1792      +14     
============================================
  Files           402      404       +2     
  Lines         10520    10614      +94     
  Branches       1338     1352      +14     
============================================
+ Hits           7048     7138      +90     
+ Misses         2783     2782       -1     
- Partials        689      694       +5     
Files with missing lines Coverage Δ
...latform/android/repository/SubmissionRepository.kt 100.00% <100.00%> (ø)
...ndroid/ui/datacollection/DataCollectionFragment.kt 95.65% <100.00%> (+4.74%) ⬆️
.../android/ui/datacollection/DataCollectionScreen.kt 87.77% <100.00%> (+1.19%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerUiEffect.kt 100.00% <100.00%> (ø)
...tform/domain/model/locationofinterest/LoiReport.kt 100.00% <100.00%> (ø)
.../home/mapcontainer/HomeScreenMapContainerScreen.kt 60.34% <80.00%> (+1.08%) ⬆️
...undplatform/domain/usecases/GetLoiReportUseCase.kt 90.74% <95.23%> (+1.15%) ⬆️
...rg/groundplatform/feature/pdf/LoiReportExporter.kt 91.66% <91.66%> (ø)
...droid/ui/datacollection/DataCollectionViewModel.kt 79.51% <40.00%> (-0.81%) ⬇️
...platform/domain/model/submission/SubmissionData.kt 10.00% <0.00%> (+10.00%) ⬆️
... and 6 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira andreia-ferreira marked this pull request as ready for review June 24, 2026 03:03
@andreia-ferreira andreia-ferreira merged commit 0f61b14 into master Jun 25, 2026
19 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3739/pdf-report-impl branch June 25, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instant offline PDF report

2 participants