Gracefully handle InvalidTestcaseError in variant and minimize tasks - #5406
Merged
Conversation
This was referenced Jul 30, 2026
aakallam
approved these changes
Jul 30, 2026
dylanjew
force-pushed
the
dylanj/task-errors-4
branch
from
July 31, 2026 18:14
e66fc23 to
d286fd8
Compare
dylanjew
force-pushed
the
dylanj/task-errors-4
branch
from
August 3, 2026 14:01
d286fd8 to
2482cce
Compare
dylanjew
force-pushed
the
dylanj/task-errors-4
branch
from
August 3, 2026 20:32
2482cce to
15c335a
Compare
…ask utasks Catch `errors.InvalidTestcaseError` when retrieving testcase entities in utask_preprocess and utask_postprocess of variant_task and minimize_task, returning cleanly without raising an unhandled exception.
dylanjew
force-pushed
the
dylanj/task-errors-4
branch
from
August 6, 2026 14:56
15c335a to
cfa9011
Compare
javanlacerda
approved these changes
Aug 6, 2026
dylanjew
added a commit
that referenced
this pull request
Aug 6, 2026
In `_MetricRecorder.__exit__`, check whether the exception inherits from `errors.Error `or `testcase_manager.TestcaseManagerError` and record the coresponding error_condition instead of `'UNHANDLED_EXCEPTION'`. We want to alert based on `UNHANDLED_EXCEPTION`, and these user defined Errors represent exceptional but expected scenariors in Clusterfuzz where the task is not meant to succeed. For example, there is no build for a variant task that we triggered, or the fuzzer is no longer valid. In these cases, we typically want to ACK the task and skip it, but these expected errors make it hard to set up alerts on real issues. Here's an example of [logs](https://cloudlogging.app.goo.gl/yMccrYFjRKxeJ1G68) of 2 deleted Testcases going through the Variant task, failing, and getting retried multiple times and triggering an alert due to the postprocess error rate spikes above 20% b/542644855 ### Testing deployed to dev. haven't seen any of these new metrics yet but no errors either. ### Related PRs 1. **This PR:** #5402 2. #5403 3. #5405 4. #5406
dylanjew
added a commit
that referenced
this pull request
Aug 6, 2026
Catch `TargetNotFoundError` and `InvalidFuzzerError` in variant_task.utask_preprocess, logging a warning and returning None to cleanly skip incompatible jobs without logging an exceptional metric. When we schedule variant tasks, we aggressively schedule variant tasks to determine whether the crash can repro on other platforms/builds. We don't know whether all of these are valid combiniations, so many of these tasks can fail when trying to set up the build. Note: hide whitespace b/542644855 ### Testing deployed to dev. haven't seen any of these new metrics yet but no errors either. ### Related PRs 1. #5402 2. **This PR:** #5403 3. #5405 4. #5406
dylanjew
added a commit
that referenced
this pull request
Aug 6, 2026
…tasks (#5405) During post minimize tasks, if a test case is deleted or marked duplicate for whatever reason, we should not continue processing the post minimize tasks. This PR stops scheduling and processing for these tasks. In `commands.process_command_impl`, short-circuit and ack the message if a testcase-based task receives a deleted or duplicate testcase. In `task_creation.create_postminimize_tasks`, skip scheduling tasks on duplicate testcases. Note: hide whitespace b/542644855 ### Testing deployed to dev. haven't seen any of these new metrics yet but no errors either. ### Related PRs 1. #5402 2. #5403 3. **This PR:** #5405 4. #5406
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch
errors.InvalidTestcaseErrorwhen retrieving testcase entities in utask_preprocess and utask_postprocess of variant_task and minimize_task, returning cleanly without raising an unhandled exception.Variant tasks are notoriously error prone because we attempt to repro a crash by fanning out across builds/platforms which might not be supported combinations for whatever reasons. The goal here is to reduce the noise from expected failures so we can alert on real issues.
b/542644855
Testing
deployed to dev. haven't seen any of these new metrics yet but no errors either.
Related PRs