fix(streaming): Ensure final partial=False frame is always yielded#6096
Open
xuanyang15 wants to merge 1 commit into
Open
fix(streaming): Ensure final partial=False frame is always yielded#6096xuanyang15 wants to merge 1 commit into
xuanyang15 wants to merge 1 commit into
Conversation
The `StreamingResponseAggregator.close()` method previously returned `None` if it didn't accumulate text or parts, such as for safety blocks or pure function calls. This caused clients (e.g., Vertex AI Reasoning Engine) to hang indefinitely waiting for a `partial=False` termination frame, and caused loops to break prematurely. This fix ensures `close()` always returns a final `LlmResponse(partial=False)` as long as a response exists, carrying over any `error_code`, `error_message`, and `usage_metadata`, regardless of whether `PROGRESSIVE_SSE_STREAMING` is enabled. Added parameterized unit tests to verify behavior across both streaming modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StreamingResponseAggregator.close()method previously returnedNoneif it didn't accumulate text or parts, such as for safety blocks or pure function calls. This caused clients (e.g., Vertex AI Reasoning Engine) to hang indefinitely waiting for apartial=Falsetermination frame, and caused loops to break prematurely.This fix ensures
close()always returns a finalLlmResponse(partial=False)as long as a response exists, carrying over anyerror_code,error_message, andusage_metadata, regardless of whetherPROGRESSIVE_SSE_STREAMINGis enabled. Added parameterized unit tests to verify behavior across both streaming modes.This is to import cd81f7b to v1 branch.