refactor: Remove unused imports across src#6095
Closed
Jacksunwei wants to merge 1 commit into
Closed
Conversation
Delete genuinely unused imports throughout src/. Imports that look unused but are intentional are preserved: - Re-export hubs keep their symbols via the `import X as X` convention (dependency shims, adk_web_server, a2a executor utils, tools/api_registry). - Optional-dependency availability probes inside try/except and a few defensive imports are kept with `# noqa: F401`. Also annotate Context._output_for_ancestors once before the if/else instead of in both branches, fixing a latent mypy [no-redef] that surfaces once the file is touched. No behavior change. Change-Id: I3fc08563409421ab83032aebc3d70973fd9767bf
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Merge #6095 ## Summary Removes genuinely unused imports throughout `src/`. No behavior change — a no-brainer cleanup. Imports that *look* unused but are intentional are **preserved**: - **Re-export hubs** keep their symbols via the `import X as X` convention (dependency shims, `adk_web_server`, `a2a/executor/utils`, `tools/api_registry`). - **Optional-dependency availability probes** inside `try/except` and a few defensive imports are kept with `# noqa: F401`. Also annotates `Context._output_for_ancestors` once before the `if/else` instead of in both branches, fixing a latent mypy `[no-redef]` that surfaces once the file is touched. ## Test plan - [x] `import google.adk` smoke test passes - [x] No `__init__.py` public re-exports removed - [x] Tooling/enforcement (ruff config + pre-commit hook) deliberately kept out — that lands in a follow-up PR Co-authored-by: Wei Sun (Jack) <weisun@google.com> COPYBARA_INTEGRATE_REVIEW=#6095 from google:chore/remove-unused-imports e7c24f6 PiperOrigin-RevId: 931258421
Collaborator
|
Thank you @Jacksunwei for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit b79096a. Closing this PR as the changes are now in the main branch. |
This was referenced Jun 12, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Merge #6097 ## Summary Adopts **ruff** to enforce unused-import (F401) hygiene going forward, so dead imports are caught automatically instead of relying on IDE highlights. (The bulk one-time cleanup already landed in #6095; this is just the tooling.) - `[tool.ruff]` in `pyproject.toml`: select `F401`, exempt `__init__.py` (intentional public re-exports), and exclude four files that hardcode `googleapis.com` URLs so cleanup doesn't trip the `check-file-contents` mTLS policy. - ruff pre-commit hook scoped to `src/`. - `scripts/run_precommit_checks.py` (the no-git standalone runner) learns the ruff hook, passing `--force-exclude` so excludes are honored on explicit file args. - Pin `ruff` in the dev extra to match the hook version. ## Test plan - [x] `ruff check src/` passes (excludes honored) - [x] pre-commit ruff hook runs green - [x] standalone runner check/fix modes verified Co-authored-by: Wei Sun (Jack) <weisun@google.com> COPYBARA_INTEGRATE_REVIEW=#6097 from google:chore/adopt-ruff-f401 b063652 PiperOrigin-RevId: 931304052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes genuinely unused imports throughout
src/. No behavior change — a no-brainer cleanup.Imports that look unused but are intentional are preserved:
import X as Xconvention (dependency shims,adk_web_server,a2a/executor/utils,tools/api_registry).try/exceptand a few defensive imports are kept with# noqa: F401.Also annotates
Context._output_for_ancestorsonce before theif/elseinstead of in both branches, fixing a latent mypy[no-redef]that surfaces once the file is touched.Test plan
import google.adksmoke test passes__init__.pypublic re-exports removed