Skip to content

Fix/ollama replace sysout with logger#1364

Open
manojkumarredbus wants to merge 479 commits into
google:mainfrom
redbus-labs:fix/ollama-replace-sysout-with-logger
Open

Fix/ollama replace sysout with logger#1364
manojkumarredbus wants to merge 479 commits into
google:mainfrom
redbus-labs:fix/ollama-replace-sysout-with-logger

Conversation

@manojkumarredbus

Copy link
Copy Markdown

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed java test results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • My pull request contains a single commit.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

Sandeep-BA and others added 30 commits November 25, 2025 23:24
fix: Saving session state to postgres while appendEvent happens.
feat(HITL): Let ADK resume after HITL approval is present
Agent Config Changes modified as per adk python
fix: Align InMemorySessionService listSessions with Python implementa…
claude and others added 27 commits June 20, 2026 19:58
A live two-turn session showed Gemini Live emits one usageMetadata event
per turn, each reporting that turn's own usage (total = prompt +
candidates) rather than a session-cumulative running total. Keeping the
latest value therefore dropped all earlier turns and undercounted
multi-turn sessions.

Accumulate by summing scalar counts and per-modality token counts across
events so the aggregate reflects true session totals. Verified end-to-end
against a live session: per-turn totals 892 and 1044 sum to 1936.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWJMsUqoQgsxLScGRk7uB2
feat: Add ADK PR Triaging Agent for google/adk-java
…th-logger

Fix/ollama replace sysout with logger
…th-logger

feat: add getter/setter for numCtx and think in OllamaBaseLM
@hemasekhar-p hemasekhar-p self-assigned this Jul 22, 2026
@hemasekhar-p

Copy link
Copy Markdown
Contributor

Hi @manojkumarredbus, thank you for your contribution! We appreciate you taking the time to submit this pull request. To proceed with the review, could you please address the following,

  1. Please provide description of your PR and make sure all pre checks are passing.
  2. Please include corresponding unit tests to verify your changes.
  3. As per our contribution policy, please squash your changes into a single commit and make sure your PR having only your changes.
  4. Please resolve the current Maven build failures.

@hemasekhar-p hemasekhar-p added the waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants