Fix/ollama replace sysout with logger#1364
Open
manojkumarredbus wants to merge 479 commits into
Open
Conversation
adk google merge
google adk merge
Google adk merge
Google adk merge
Google adk merge
adk merge
Google adk merge
ADK changes
Google adk merge
adk merge
fix: Saving session state to postgres while appendEvent happens.
feat(HITL): Let ADK resume after HITL approval is present
Agent Config Changes modified as per adk python
fix: Align InMemorySessionService listSessions with Python implementa…
A live two-turn session showed Gemini Live emits one usageMetadata event per turn, each reporting that turn's own usage (total = prompt + candidates) rather than a session-cumulative running total. Keeping the latest value therefore dropped all earlier turns and undercounted multi-turn sessions. Accumulate by summing scalar counts and per-modality token counts across events so the aggregate reflects true session totals. Verified end-to-end against a live session: per-turn totals 892 and 1044 sum to 1936. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWJMsUqoQgsxLScGRk7uB2
S3 artifact service
Upstream merge
…s/adk-java into token_tracking
feat: Add ADK PR Triaging Agent for google/adk-java
Token tracking
…th-logger Fix/ollama replace sysout with logger
…th-logger feat: add getter/setter for numCtx and think in OllamaBaseLM
Merge pr 177
Contributor
|
Hi @manojkumarredbus, thank you for your contribution! We appreciate you taking the time to submit this pull request. To proceed with the review, could you please address the following,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed java test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.