Add a check which tests test-mindeps bounds - #1276
Merged
Merged
Conversation
Load `test-mindeps` and `dependencies` out of pyproject data, and compare them to ensure that the specifiers in `test-mindeps` always contain the minimum version listed in `dependencies`. This is a new tox env and runs in CI. It should force bad test-mindeps updates from dependabot to fail.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
July 1, 2026 16:24
derek-globus
approved these changes
Jul 20, 2026
| r for r in group_resolver.lookup("test-mindeps") if isinstance(r, Requirement) | ||
| ] | ||
|
|
||
| dependencies: tuple[str, ...] = dj.read.dependencies() |
Contributor
There was a problem hiding this comment.
Can you remind me where MDDJ is sourcing this metadata from? Is this also coming from pyproject.toml?
Member
Author
There was a problem hiding this comment.
It pulls data from pyproject.toml as much as possible. If a field is not present there, it will fallback to a more complex (and slower) path which asks the package build system to get that information.
I should do a better job of documenting this, probably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load
test-mindepsanddependenciesout of pyproject data, and comparethem to ensure that the specifiers in
test-mindepsalways contain theminimum version listed in
dependencies.This is a new tox env and runs in CI. It should force bad test-mindeps
updates from dependabot to fail.