feat: system-aware tiered parallel pytest with cross-platform hardening#2877
feat: system-aware tiered parallel pytest with cross-platform hardening#2877LahkLeKey wants to merge 36 commits into
Conversation
…and on-behalf review standards (#2) * feat: add system-aware parallel pytest tiers * fix: honor cgroup v1 cpu quota for parallel worker sizing * docs: add on-behalf AI review disclosure standard * fix: support cpuacct,cpu cgroup v1 quota mount layout * test: make --parallel activate xdist workers * test: harden bash path assertions on Windows * test: handle zero available memory in parallel sizing * test: make symlink skip capability-based on Windows * test: replace platform skips with capability checks * test: address open review findings for path and xdist checks * test: restore strict setup task assertions * test: honor explicit -n auto and clean InvalidMetadata fallback * test: floor cgroup quota workers and remove dead helper * test: mock os.access for relative installer path case * test: tighten path checks and report effective workers * test: skip parallel xdist hooks when plugin is disabled * test: simplify bash path normalization helper * test: harden parallel args and cwd-safe upgrade tests
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves cross-platform test robustness (especially on Windows/Git Bash path translation) and adds an opt-in pytest --parallel mode that chooses a conservative worker count based on CPU/memory/OS caps (via pytest-xdist).
Changes:
- Added system-aware parallel worker sizing utilities and
--parallel/tier/max-workers pytest options, plus new unit tests. - Relaxed or normalized several path-based assertions to handle Windows/Git Bash path formats and filesystem limits.
- Updated contributor docs and PR template to mention the new parallel test option and AI attribution guidance.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_timestamp_branches.py | Adds Windows-tolerant path assertion helper + relaxes long-path failure expectation on Windows. |
| tests/test_setup_tasks.py | Adjusts TASKS_TEMPLATE assertions to be Windows/Git Bash tolerant. |
| tests/test_setup_plan_no_overwrite.py | Normalizes bash-emitted paths to Windows paths for assertions. |
| tests/test_self_upgrade_execution.py | Makes self-upgrade tests less POSIX-only via mocking/path changes. |
| tests/test_self_upgrade_detection.py | Makes InvalidMetadataError test runnable on more Python versions by patching conditionally. |
| tests/test_parallel_workers.py | New tests covering worker sizing, cgroup parsing, and CLI arg parsing helpers. |
| tests/test_authentication.py | Makes permission-warning test runnable on Windows via patching. |
| tests/integrations/test_integration_subcommand.py | Adds a capability check for Windows directory symlink creation and skips accordingly. |
| tests/integrations/test_cli.py | Makes chmod-mode assertion Windows-tolerant by spying on chmod calls. |
| tests/conftest.py | Adds --parallel pytest option + early xdist arg injection, configuration, and report header. |
| tests/_parallel.py | New module implementing CPU/memory detection and recommended worker computation. |
| pyproject.toml | Adds pytest-xdist to test extras. |
| CONTRIBUTING.md | Documents pytest --parallel usage and tuning options. |
| .github/PULL_REQUEST_TEMPLATE.md | Updates checklist to mention parallel tests + AI comment attribution checkbox. |
Comments suppressed due to low confidence (1)
tests/test_self_upgrade_execution.py:1
- These tests no longer appear gated to POSIX, but they still rely on POSIX executable-bit semantics (
chmod(0o644)and (likely)os.access(..., X_OK)). On Windows,os.access(..., X_OK)can behave like an existence check, so this test can fail (or become meaningless) when run under--parallel/xdist on Windows. Suggested fix: reintroduce a POSIX-only marker for this specific test, or explicitly patchspecify_cli._version.os.accessto returnFalsefor the installer path in this test so the behavior is deterministic cross-platform.
"""Installer execution, verification, and error-path tests for `specify self upgrade`."""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for 127ac67: addressed all currently open review comments and posted inline 'Resolved by 127ac67' replies on each thread. Also refreshed the PR description Review Fix Ledger to track additive fixes and reduce feedback-loop churn. Validation: uv run pytest tests/test_setup_tasks.py tests/test_timestamp_branches.py tests/test_setup_plan_no_overwrite.py tests/test_self_upgrade_execution.py tests/test_parallel_workers.py -q (160 passed). |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for a227754: addressed all currently open review comments and posted inline 'Resolved by a227754' replies on each thread. Refreshed the PR description Review Fix Ledger so additive follow-up fixes remain tracked and feedback-loop churn is reduced. Validation: uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py tests/test_setup_plan_no_overwrite.py tests/test_self_upgrade_execution.py tests/integrations/test_cli.py -q (239 passed). |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.4 mini). Addressed the latest review round in commit 42571cc (Windows self-upgrade test stability, xdist dist-default handling, tightened Windows shell-path matching, and interpreter-generic comments in common.sh). Focused validation: uv run pytest tests/test_self_upgrade_execution.py tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py tests/test_setup_plan_no_overwrite.py tests/integrations/test_cli.py -q (239 passed). |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.4 mini). Backfilled the PR review ledger with commit-level drilled-down details (trigger, code-surface, validation), added a scope-creep guard section to keep review changes bounded to this feature and coverage outcomes, and re-verified open threads. Current open-thread count is reviewer-owned conversation state; all open threads contain explicit inline |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Addressed the latest four review comments in commit b12061f: sysconf page-size fallback portability, Windows PATH separator handling in shim-based setup-tasks test, simplification of parallel pytest flow by removing subprocess reinvocation, and explicit xfail for Windows long-path truncation edge case. Validation: uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py -q (133 passed, 1 xfailed). PR description was backfilled with drilled-down add-on ledger details and updated open-thread status notes to reduce feedback-loop churn. |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Addressed the latest five review comments in commit b87e7c6: explicit xdist enablement when plugin autoload is disabled, Bash PATH separator handling for Bash subprocess shims, less brittle Windows chmod assertion semantics, realistic InvalidMetadataError coverage behavior, and UNC-preserving slash normalization with direct helper tests. Validation: uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/integrations/test_cli.py tests/test_self_upgrade_detection.py tests/test_path_utils.py -q (176 passed, 1 skipped). PR description was backfilled with this add-on in the review ledger and open-thread status notes were updated. |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Addressed the latest three review comments in commit 8bb0ca4: UNC over-prefix normalization in shared path helpers, precise explicit-xdist plugin matching to avoid substring false positives, and interpreter-fallback wording alignment in bash resolver comments. Validation: uv run pytest tests/test_parallel_workers.py tests/test_path_utils.py tests/test_setup_tasks.py -q (55 passed). PR description review ledger has been backfilled with this add-on and open-thread resolved-by status updated. |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commits 7727673 and 1858a93. Addressed latest actionable comments:
Validation runs:
Inline replies have been posted on all current open review threads as |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
tests/test_self_upgrade_execution.py:1
- This test is intended to cover the non-executable-installer error path, but it no longer explicitly forces the installer to be non-executable (the prior chmod was removed) and it also doesn’t patch
os.access(..., X_OK)like other tests do. That makes the test outcome dependent on platform/filesystem defaults (e.g., umask and Windowsos.accesssemantics). To make it deterministic, either restore an explicit non-executable setup on platforms where it’s meaningful (e.g., chmod to 0o644 on POSIX) or patchspecify_cli._version.os.accessto returnFalsewithin this test.
"""Installer execution, verification, and error-path tests for `specify self upgrade`."""
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest comments:
Validation run:
Inline replies have been posted on all current open review threads as |
| _is_safe_manifest_relative_path() { | ||
| local manifest_file="$1" | ||
| [ -n "$manifest_file" ] || return 1 | ||
|
|
||
| # Reject absolute and drive-prefixed paths. | ||
| case "$manifest_file" in | ||
| /*|\\*|[A-Za-z]:*) return 1 ;; | ||
| esac |
There was a problem hiding this comment.
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex).
Resolved by da4953a.
| def normalize_path_text(path_value: str) -> str: | ||
| """Normalize slashes and repeated separators for string checks.""" | ||
| normalized = path_value.replace("\\", "/") | ||
| if path_value.startswith("\\\\?\\") or path_value.startswith("\\\\.\\"): | ||
| return re.sub(r"/{2,}", "/", normalized) | ||
| is_unc_backslash = path_value.startswith("\\\\") | ||
| is_unc_slash_double = normalized.startswith("//") and not normalized.startswith("///") | ||
| is_unc_slash_overprefixed = normalized.startswith("////") | ||
| if is_unc_backslash or is_unc_slash_double or is_unc_slash_overprefixed: | ||
| unc_tail = normalized.lstrip("/") | ||
| return "//" + re.sub(r"/{2,}", "/", unc_tail) |
There was a problem hiding this comment.
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex).
Resolved by da4953a.
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex).\n\nClosing this upstream PR to continue iteration in LahkLeKey/spec-kit after merging the PR branch work into the fork's main branch. |
Description
See below AI Disclosure for more details
Testing
uv run specify --helpuv sync && uv run pytest(optionallyuv run pytest --parallel --parallel-tier medium)AI Disclosure
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex).
Continuation for LahkLeKey#2
Summary
This PR introduces system-aware optional parallel test execution for Spec Kit's pytest suite and hardens associated cross-platform tests and review-process hygiene.
Main Prompt Loop (After Feat Scaffold)
What changed
Added bounded parallel test mode via pytest flags:
--parallel--parallel-tier(low|medium|high)--parallel-max-workersImplemented worker sizing based on system constraints:
effective CPU count
available/total memory
cgroup v2 CPU quota (
/sys/fs/cgroup/cpu.max)cgroup v1 CPU quota (
cpu,cpu,cpuacct,cpuacct,cpulayouts)platform caps by tier
Wired xdist integration safely in
tests/conftest.py:respects explicit
-n/--numprocesses(including-n auto)skips injection/reinvoke when xdist is disabled (
-p no:xdist/-pno:xdist)handles
--sentinel correctly by injecting xdist args before positional boundaryreports effective worker selection in pytest header
Added/updated regression coverage for:
cgroup quota parsing behavior
zero-memory boundaries
xdist disable and
--sentinel edge casescross-platform path handling in bash-based tests
CWD-safe relative installer path tests (
monkeypatch.chdir)Validation
Fresh full-suite verification on this branch:
uv run pytest -q --parallel --parallel-tier high -rsResult:
3669 passedReview quality controls / loop prevention evidence
Source hardening was completed first in fork PR
LahkLeKey/spec-kit#2and then squashed for upstream submission.Evidence used before opening this upstream PR:
All active review findings in the fork PR were answered with on-behalf inline follow-ups including explicit
Resolved by <sha>references.A persistent "Review Fix Ledger" was backfilled into the fork PR description to track additive review fixes across rounds and reduce recurrence loops.
The final outstanding unresolved thread in the fork PR has an explicit
Resolved byreply from the PR owner and no pending unaddressed action item.Scope
Review Fix Ledger (On Behalf Of @LahkLeKey)
This section tracks additive review-driven fixes to avoid recurring feedback loops across rounds.
127ac67a227754os.accesspatching in self-upgrade tests, shared conftest helpers for argument parsing/injection, tightened path helper behavior, interpreter-generic resolver comments42571cc--distintent while defaulting toworkstealonly when unsetuv run pytest tests/test_self_upgrade_execution.py tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py tests/test_setup_plan_no_overwrite.py tests/integrations/test_cli.py -q(239 passed)b12061fSC_PAGESIZEfallback for sysconf page-size detection, usedos.pathsepin Windows PATH shim setup, removed subprocess pytest reinvocation pathway from conftest, replaced silent Windows early-return with explicitpytest.xfailfor long-path limitationuv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py -q(133 passed, 1 xfailed)b87e7c6--parallelinjection under plugin autoload disable when xdist is explicitly enabled, restored Bash PATH separator usage in Bash subprocess test, loosened Windows chmod assertion to stable safety guarantees, skipped unreachable InvalidMetadataError simulation on runtimes lacking that class, preserved UNC leading//in path normalization and added path-utils unit testsuv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/integrations/test_cli.py tests/test_self_upgrade_detection.py tests/test_path_utils.py -q(176 passed, 1 skipped)8bb0ca4////server/...), replaced substring-based xdist enable detection with exact plugin-name matching (xdist/xdist.*), and updated bash resolver fallback comment to reflect generic python interpreter availabilityuv run pytest tests/test_parallel_workers.py tests/test_path_utils.py tests/test_setup_tasks.py -q(55 passed)55819c7os.accessuv run pytest tests/test_setup_tasks.py tests/test_self_upgrade_execution.py -q(46 passed) plus targeted checks (2 passed)4c2a128///...mis-normalization), avoided trailing:when inherited PATH is empty in Git Bash shim setup, and made Windows chmod assertion resilient to positional/keyword mode invocationuv run pytest tests/test_path_utils.py tests/test_setup_tasks.py tests/integrations/test_cli.py -q(105 passed)1ce7a90--parallel, and chmod target precision--paralleldetection to args before--, and tightened Windows chmod assertions to match the plan-template target (final or expected temp-write form)uv run pytest tests/test_path_utils.py tests/test_parallel_workers.py tests/integrations/test_cli.py tests/test_setup_tasks.py -q(135 passed)1c95074path_from_bash_outputtrimming for quotes/whitespace/CRLF, extracted sharedTASKS_TEMPLATEassertion helper in setup-tasks tests, and strengthened Windows integration assertion with explicit output-file existence checkuv run pytest tests/test_parallel_workers.py tests/test_path_utils.py tests/test_setup_tasks.py tests/integrations/test_cli.py -q(137 passed)ba72907pytest_load_initial_conftestssentinel-safe injection behavioruv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(142 passed)d7ba3f6os.pathsepin env composition, made python3-missing test unambiguous by constraining PATH to shim-only for fallback proof, made/tmpmapping fall back to raw path when mapped temp candidate is absent, and aligned early--parallel-max-workersparsing with UsageError validation semantics plus focused testsuv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(144 passed)f78887f/tmpconversion deterministic/configurable viaSPECKIT_BASH_TMPDIR, cached early parallel settings to avoid duplicate compute passes, and added focused regression tests for early-hook validation and compute-once behavioruv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(147 passed)0bb271fMEMORYSTATUSEXhandling, moved host-to-bash path conversion into shared path utils, and fixed the CONTRIBUTING markdown table renderinguv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(150 passed)8e07002:with shared bash-path conversion, reused_read_windows_memory_status()from both Windows memory detection paths, and rewrote UNC normalization checks into explicit named booleans for readabilityuv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py -q(73 passed)822e9f8.tmp_*artifacts so ad hoc review/PR files are not accidentally committed.tmp_*to the root.gitignorealongside the existing*.tmprule so temporary PR/body/thread snapshots stay out of version controlgit diff --check -- .gitignoree00e647find-based preset fallback scan to preserve prior hidden-directory behavior, and restored PR template checklist nesting so the rendered hierarchy remains stableuv run pytest tests/test_setup_tasks.py -q(27 passed)71e9e04--parallelno-op behavior_run_bash_resolve_templatePATH override to prepend instead of replace, strengthened python-fallback shim test to validate-candSPECKIT_REGISTRY, and made--parallelskip xdist injection/requirement when computed workers resolve to 1 (with focused regression tests)uv run pytest tests/test_setup_tasks.py tests/test_parallel_workers.py -q(66 passed)100b994process-substitution pipelines in preset fallback scans with9d3ddbcresolve_template_python_cmd()helper that only acceptspythonwhen it reports Python 3 before registry parsing, added a regression test that skips a non-Python3pythonshim and falls back deterministically, and made the Windows chmod test patchPath.chmodas a no-op spy instead of executing real chmoduv run pytest tests/test_setup_tasks.py tests/integrations/test_cli.py -q(105 passed)1c10388no:xdist/no:xdist.*matches, replacedfind ... -not -namewith portable! -namepredicates in preset scans, and scoped the authPath.statpatch so it delegates to the real implementation for non-target paths while keeping the warning-path assertion focuseduv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_authentication.py -q(149 passed)afd927dpython3andpythoninterpreter selection, added deterministic PATH-replacement support in setup-task resolver test helper, and hardened fallback/interpreter shim tests to guarantee intended branch coverage across host environmentsuv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_authentication.py -q(150 passed)005a5danormalized_parts()Windows-only to preserve non-Windows drive distinctions, memoizedresolve_template_python_cmd()interpreter selection per shell session to avoid repeated process probes, and changed auth test stat-target matching to normalized absolute string-path comparison for robust derived-path handlinguv run pytest tests/test_path_utils.py tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_authentication.py -q(159 passed)8e922e0--parallelerror branching to report install guidance when xdist is absent and autoload guidance only when installed-but-not-loaded, and preserved drive components in normalized path comparisons to prevent cross-drive false positives on Windowsuv run pytest tests/test_setup_tasks.py tests/test_parallel_workers.py tests/test_path_utils.py tests/test_authentication.py -q(163 passed)7af875dos.namemutation in auth test, and missing directresolve_template_contentedge-case coverageresolve_templateandresolve_template_content, pre-warmed interpreter selection in parent shell to preserve cache across process-substitution calls, removed directos.namemonkeypatching in auth warning test via scopedpatch.object, and added directresolve_template_contentCRLF/fallback-determinism regressionsuv run pytest tests/test_setup_tasks.py tests/test_authentication.py tests/test_parallel_workers.py tests/test_path_utils.py -q(165 passed)0b201ac(priority, preset_id)for deterministic ordering, maderesolve_template_contentmanifest parsing use cached selected Python command instead of hard-codedpython3, removed unusedmonkeypatchfixture parameter, and added regressions for tie-order selection and manifest parsing through Python fallback pathuv run pytest tests/test_setup_tasks.py tests/test_authentication.py tests/test_parallel_workers.py tests/test_path_utils.py -q(167 passed)7727673wraps=Path.chmod, and added regressions for UNC mismatch and unsafe preset-id skipping in both path/content resolversuv run pytest tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py tests/test_authentication.py tests/test_parallel_workers.py -q(247 passed)1858a93strategy/manifest_fileexplicit per iteration inresolve_template_contentand added regression coverage ensuring manifest state does not leak between presetsuv run pytest tests/test_setup_tasks.py tests/test_path_utils.py tests/test_authentication.py tests/integrations/test_cli.py tests/test_parallel_workers.py -q(248 passed)45d0fbd..preset-id rejection, non-Windows//UNC marker scope, and PR checklist nestingv1..0, scoped UNC marker behavior to Windows in path-part comparison logic, restored nested checklist indentation in PR template, and added regressions for mixed-type priority ordering and benign double-dot preset IDsuv run pytest tests/test_setup_tasks.py tests/test_path_utils.py tests/test_authentication.py tests/integrations/test_cli.py tests/test_parallel_workers.py -q(250 passed)2b5fa8e_run_bash_resolve_template*helper implementations into a single shared_run_bash_template_resolver(...)with thin wrappers forresolve_templateandresolve_template_contentto reduce drift risk while preserving call-site clarityuv run pytest tests/test_setup_tasks.py tests/test_self_upgrade_execution.py -q(61 passed)015b976--parallelwhen no--sentinel is present, removed redundantresolve_template_python_cmdinvocation inside_iter_preset_ids_orderedby reusing the pre-selected cached command, and added regression coverage for deterministic adjacent injection behavioruv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py -q(81 passed)093b04bfile:traversal hardening and import duplication cleanup_is_safe_manifest_relative_pathto reject absolute/drive-prefixed paths and any..segment after slash/backslash normalization, switched manifest candidate gating inresolve_template_contentto that helper, added direct bash regression coverage for unsafe/safe manifest path inputs, and consolidatedtests._path_utilsimports into one statementuv run pytest tests/test_setup_tasks.py tests/test_path_utils.py -q(63 passed)78d7988\rfrom manifest parserstrategy/manifest_filefields before safety checks and candidate lookup, excluded\\?\\and\\.\\prefixed paths from UNC normalization/sentinel handling, raised explicitpytest.UsageErrorwhen--parallel-tieror--parallel-max-workersis provided without a value, and added focused regressions across setup-tasks/path-utils/parallel workersuv run pytest tests/test_setup_tasks.py tests/test_parallel_workers.py tests/test_path_utils.py -q(111 passed)da4953aX:/...andX:\\...) so benign relative names likea:overlay.mdare allowed, extended device-path detection to recognize slash-form prefixes (//?/,//./) before UNC classification, and added regressions for both guard behaviorsuv run pytest tests/test_setup_tasks.py tests/test_path_utils.py -q(68 passed)Open Review Thread Status
Resolved by 42571cc.Resolved by b12061f.Resolved by b87e7c6.Resolved by 8bb0ca4.Resolved by 55819c7.Resolved by 4c2a128.Resolved by 1ce7a90.Resolved by 1c95074.Resolved by ba72907.Resolved by d7ba3f6.Resolved by f78887f.Resolved by 0bb271f.Resolved by 8e07002.Resolved by 822e9f8.Resolved by e00e647.Resolved by 71e9e04.Resolved by 100b994.Resolved by 9d3ddbc.Resolved by 1c10388.Resolved by afd927d.Resolved by 005a5da.Resolved by 8e922e0.Resolved by 7af875d.Resolved by 0b201ac.Resolved by 7727673.Resolved by 1858a93.Resolved by 45d0fbd.Resolved by 2b5fa8e.Resolved by 015b976.Resolved by 093b04b.Resolved by 78d7988.Resolved by da4953a.POSIX vs Git Bash Guard
\\server\shareforms), not a generic rule for any leading//POSIX path.Scope Creep Guard (Copilot Review Guidance)
--parallelbehavior, worker sizing, xdist argument flow, cross-platform path correctness, and failing/fragile tests in touched files.HEADbefore requesting additional edits.HEAD.$(...)) if cache state must persist; prefer in-shell function calls that set/read global state directly.os.namedirectly in tests; use narrowly scoped module-level patch contexts or dedicated predicates to avoid cross-test side effects.resolve_templateandresolve_template_contenton the same interpreter-selection and preset-ordering helpers; avoid hard-coded interpreter calls in one path that bypass fallback/caching in the other.strategy,manifest_file, similar locals) so parse failures cannot leak values into subsequent entries.--) instead of appending at the end to keep ordering deterministic.file:values as strict relative paths by normalizing separators and rejecting any..segment or absolute/drive-prefixed form before candidate resolution.\r) before path validation and filesystem checks.\\?\\...or\\.\\...paths as UNC-equivalent in normalization/assertion helpers.--parallel-tieror--parallel-max-workers, raise an immediate usage error if the option is present without a value.X:/...,X:\\...) without over-matching benign colon-bearing relative names.\\?\\...and//?/...,\\.\\...and//./...) before UNC checks.2026-06-06 Add-on (commit 42571cc)
2026-06-06 Add-on (commit b12061f)
tests/_parallel.pyby trying bothSC_PAGE_SIZEandSC_PAGESIZEbefore computing total memory.tests/test_setup_tasks.pyto prepend shim paths usingos.pathsepinstead of hardcoded:.tests/conftest.pyby removing subprocess-based pytest reinvocation and relying on existing injection/configure hooks.pytest.xfail) intests/test_timestamp_branches.py.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_timestamp_branches.py -q(133 passed, 1 xfailed).2026-06-06 Add-on (commit b87e7c6)
PYTEST_DISABLE_PLUGIN_AUTOLOADintests/conftest.pyso--parallelstill injects workers when xdist is intentionally loaded via-p xdist.:) for the shim-based Bash subprocess test intests/test_setup_tasks.py.tests/integrations/test_cli.pyto assert safe mode and target directory without coupling to temp filename implementation details.tests/test_self_upgrade_detection.pyby skipping on runtimes withoutInvalidMetadataErrorinstead of fabricating an exception class.tests/_path_utils.pyand added direct helper coverage intests/test_path_utils.py.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/integrations/test_cli.py tests/test_self_upgrade_detection.py tests/test_path_utils.py -q(176 passed, 1 skipped).2026-06-06 Add-on (commit 8bb0ca4)
tests/_path_utils.pyfor over-prefixed slash inputs so replacement output stays canonical (//server/share/...), not triple-slash.tests/conftest.pyto exact plugin names (xdist,xdist.*) and avoid substring false positives.tests/test_parallel_workers.pyand UNC over-prefix normalization intests/test_path_utils.py.scripts/bash/common.shto reflect missing generic python interpreter availability, not justpython3.uv run pytest tests/test_parallel_workers.py tests/test_path_utils.py tests/test_setup_tasks.py -q(55 passed).2026-06-06 Add-on (commit 55819c7)
tests/test_setup_tasks.pyWindows shim PATH handling to preserve inherited PATH bytes while prepending the shim path for Bash subprocess execution, with an explicit comment documenting the drive-letter delimiter caveat.tests/test_self_upgrade_execution.py, relying on mockedos.access(..., X_OK)as the cross-platform executability control.uv run pytest tests/test_setup_tasks.py tests/test_self_upgrade_execution.py -q(46 passed) and targeted regression checks (2 passed).2026-06-06 Add-on (commit 4c2a128)
tests/_path_utils.pyso UNC-preserving behavior applies only to native Windows UNC-style inputs, preventing POSIX leading-slash paths (for example///usr/bin) from being pinned to a double-slash prefix.tests/test_setup_tasks.pyto avoid appending a trailing PATH separator when inherited PATH is empty.tests/integrations/test_cli.pyWindows chmod assertion to accept positional or keyword mode invocation.tests/test_path_utils.py.uv run pytest tests/test_path_utils.py tests/test_setup_tasks.py tests/integrations/test_cli.py -q(105 passed).2026-06-06 Add-on (commit 1ce7a90)
tests/_path_utils.pyto preserve slash-normalized UNC inputs (//server/share/...) while continuing to normalize POSIX triple-leading-slash paths correctly.tests/conftest.pysopytest_load_initial_conftestsonly honors--parallelbefore the--sentinel.tests/integrations/test_cli.pyto require the expected plan-template target path shape.tests/test_parallel_workers.pyandtests/test_path_utils.py.uv run pytest tests/test_path_utils.py tests/test_parallel_workers.py tests/integrations/test_cli.py tests/test_setup_tasks.py -q(135 passed).2026-06-06 Add-on (commit 1c95074)
tests/_parallel.pyto use the most permissive known OS cap whenplatform_nameis unrecognized, avoiding unnecessary throttling on non-Windows unknown platforms.tests/_path_utils.pysopath_from_bash_outputtrims shell artifacts (quotes, whitespace, CRLF) before path conversion._assert_tasks_template_matches(...)intests/test_setup_tasks.pyto centralize repeated POSIX-vs-Windows shell path assertions.written.is_file()verification intests/integrations/test_cli.pyfor Windows template-write safety checks.tests/test_parallel_workers.pyandtests/test_path_utils.py.uv run pytest tests/test_parallel_workers.py tests/test_path_utils.py tests/test_setup_tasks.py tests/integrations/test_cli.py -q(137 passed).2026-06-06 Add-on (commit ba72907)
_assert_tasks_template_matches(...)intests/test_setup_tasks.pyto compare resolved-equivalent paths on non-Windows, preventing false negatives when shell output contains equivalent non-canonical segments.tests/test_setup_tasks.pyfor: python fallback whenpython3is unavailable, CRLF trimming for preset IDs, and deterministic alphabetical directory fallback when registry parsing fails.tests/test_parallel_workers.pythat exercisepytest_load_initial_conftestsaround--sentinel boundaries and injection placement.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(142 passed).2026-06-07 Add-on (commit d7ba3f6)
tests/test_setup_tasks.pyto useos.pathsepwhen prepending shim paths in the invoke-separator test and adjusted fallback-proof tests to avoid accidentalpython3discovery from host paths.tests/_path_utils.pyso/tmp/...mapping on Windows falls back to raw path when the mapped tempdir candidate does not exist.tests/conftest.pyearly parallel settings parsing to raisepytest.UsageErrorfor invalid or< 1--parallel-max-workersvalues, aligning withpytest_configurebehavior.tests/test_parallel_workers.pyfor early hook UsageError behavior.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(144 passed).2026-06-07 Add-on (commit f78887f)
tests/_path_utils.pyto preserve over-prefixed slash UNC-like inputs (////server/...) and made/tmpconversion deterministic with optional override viaSPECKIT_BASH_TMPDIR.tests/conftest.pyto cache early-computed parallel settings and reuse them inpytest_configure, avoiding duplicate compute passes in the same invocation path.tests/test_parallel_workers.pyfor compute-once behavior and early-hook max-worker validation consistency.tests/test_path_utils.pyfor over-prefixed slash UNC-like normalization and deterministic tmp mapping behavior.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(147 passed).2026-06-07 Add-on (commit 0bb271f)
tests/conftest.pyso the early injection hook no-ops inside worker processes.MEMORYSTATUSEXhandling intests/_parallel.pythrough a shared helper.tests/_path_utils.pyand updated setup-tasks tests to reuse the shared helper.CONTRIBUTING.mdso it renders correctly on GitHub.uv run pytest tests/test_parallel_workers.py tests/test_setup_tasks.py tests/test_path_utils.py tests/integrations/test_cli.py -q(150 passed).