Skip to content

Publish license categories on stable releases - #185

Merged
elrayle merged 1 commit into
elr/license-categories-migration-basefrom
elr/license-categories-simple-triggers
Nov 12, 2026
Merged

elrayle merged 1 commit into
elr/license-categories-migration-basefrom
elr/license-categories-simple-triggers

Conversation

@elrayle

@elrayle elrayle commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

First minimal upper layer above #175: change publication triggers only.

  • Replace the package-path push trigger with release: released, covering initial stable releases and prereleases promoted to stable.
  • Retain workflow_dispatch, the existing publication enablement gate, and the default-branch restriction for dispatches. Skip GitHub-marked prereleases and let release runs check out the event's tag commit using the unchanged checkout step.
  • Update the directly related publication documentation.

Provenance, generated-data comparison, generator/Makefile behavior, concurrency, OIDC, Node/npm versions, package tests, and publication commands are unchanged. Existing PRs remain open; this is a fresh PR.

Validation

Parsed the workflow YAML and checked seven focused scenarios: stable release, promotion, prerelease skip, default-branch dispatch, other-branch rejection, and disabled release/dispatch.

Replace main-push publication with release: released, retain manual dispatch and skip GitHub-marked prereleases. Allow release tag refs without changing checkout or publication behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 12, 2026 10:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Tying public npm publication to stable go-spdx releases while bypassing the default-branch check requires maintainer policy approval and validation through a real release.

No open issues 🎉

What changed in this PR

Moves license-category npm publication from package-path pushes to stable GitHub releases while retaining manual publishing.

Changes:

  • Trigger publication on stable releases, including prerelease promotions, and skip GitHub-marked prereleases.
  • Preserve the publication enablement gate and default-branch restriction for manual dispatches; release runs use the tagged commit.
  • Update publication documentation without changing build, test, or publish commands.
File Description
packages/​license-categories/​docs/​operations.md Documents release-triggered publishing and revised maintainer steps.
.github/​workflows/​publish-license-categories.yaml Replaces the push trigger with release events and adjusts event guards.

Review effort: Max (auto)

@elrayle
elrayle added this pull request to stack #188 November 12, 2026 11:28
@elrayle
elrayle merged commit f8cd51a into main Nov 12, 2026
9 checks passed
@elrayle
elrayle deleted the elr/license-categories-simple-triggers branch November 12, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants