Skip to content

create_or_update_file rejects explicitly empty file content #3883

Backlog

Description

@Elon-Jiang

Description

create_or_update_file rejects an explicitly supplied empty string with missing required parameter: content, preventing agents from creating empty package markers such as __init__.py / .gitkeep, or intentionally clearing an existing file.

The tool schema requires a string but does not impose a minimum length. The GitHub Contents API accepts empty base64 content, and push_files already distinguishes absent content from an explicitly empty string.

Reproduction

Call the tool with {"owner":"owner","repo":"repo","path":"__init__.py","branch":"main","message":"Add package marker","content":""}. Expected: a Contents API request with content: "". Actual: the tool returns an error before making any HTTP request. Updating an existing ordinary file with its current SHA fails in the same way.

Reproduced at 4e6e6c053e48aac182f7768162fef2ad42fe7d5f through CreateOrUpdateFile(...).Handler(...), using the real go-github REST client with a controlled HTTP transport. Two new regression cases fail; existing nonempty create/update cases pass. No live repository write was performed in reproduction.

I plan to allow explicitly empty content while continuing to reject absent/null content, preserving the existing exported Go input type, JSON schema, SHA validation and symlink protections. I checked the complete open PR file lists and relevant closed PRs; #3313 (binary encoding) and #2772 (GraphQL migration) retain the empty-string rejection and address different behavior.

This report and proposed fix were prepared with AI assistance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions