fix(runner): handle long prefixes in pool scheduler and IAM resource names - #5139
Merged
edersonbrilhante merged 1 commit intoJul 4, 2026
Conversation
edersonbrilhante
requested changes
Jul 3, 2026
edersonbrilhante
left a comment
edersonbrilhante
left a comment
Contributor
There was a problem hiding this comment.
@alexjurkiewicz Please sign the commits
…names The pool module's aws_scheduler_schedule_group and aws_iam_role for the scheduler both use name_prefix, which has a 38-character limit. When the module prefix is long (e.g. via multi-runner map keys), this limit is exceeded and Terraform fails. Add a local that passes the prefix through unchanged when it fits, and falls back to a truncated prefix with an md5 hash suffix when it exceeds 38 characters. This matches the existing pattern used for the pool lambda IAM role on line 80. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexjurkiewicz
force-pushed
the
fix/pool-name-prefix-length
branch
from
July 4, 2026 00:23
f84ba0c to
d268e61
Compare
Contributor
Author
|
Done, and rebased too |
edersonbrilhante
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool module's
aws_scheduler_schedule_groupandaws_iam_rolefor the scheduler both usename_prefix, which has a 38-character limit (64 max name minus 26 for Terraform's random suffix). When the module prefix is long — for example a multi-runner prefix likeself-hosted-linux-ubuntu2404-x64-2cpu-8gb— the combined${prefix}-poolexceeds 38 characters and Terraform fails.For long prefixes, the name is now truncated with an md5 hash suffix to stay within limits, matching the existing pattern used elsewhere in the module. Existing deployments with short prefixes see no resource changes.