-
-
Notifications
You must be signed in to change notification settings - Fork 472
feat(android): Report app start reason on standalone app start transaction #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buenaflor
wants to merge
2
commits into
main
Choose a base branch
from
feat/android-app-start-reason
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,7 @@ public final class ActivityLifecycleIntegration | |
| static final long APP_START_TO_UI_LOAD_CONTINUATION_MAX_GAP_NANOS = TimeUnit.MINUTES.toNanos(1); | ||
| private static final String TRACE_ORIGIN = "auto.ui.activity"; | ||
| static final String APP_START_SCREEN_DATA = "app.vitals.start.screen"; | ||
| static final String APP_START_REASON_DATA = "app.vitals.start.reason"; | ||
| static final String APP_START_TRACE_ORIGIN = "auto.app.start"; | ||
|
|
||
| private final @NotNull Application application; | ||
|
|
@@ -140,6 +141,7 @@ public void register(final @NotNull IScopes scopes, final @NotNull SentryOptions | |
|
|
||
| if (performanceEnabled && this.options.isEnableStandaloneAppStartTracing()) { | ||
| AppStartMetrics.getInstance().setHeadlessAppStartListener(this::onHeadlessAppStart); | ||
| addIntegrationToSdkVersion("StandaloneAppStart"); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needed for tracking in looker |
||
| } | ||
|
|
||
| this.options.getLogger().log(SentryLevel.DEBUG, "ActivityLifecycleIntegration installed."); | ||
|
|
@@ -286,6 +288,10 @@ private void startTracing(final @NotNull Activity activity) { | |
| appStartSamplingDecision), | ||
| appStartTransactionOptions); | ||
| appStartTransaction.setData(APP_START_SCREEN_DATA, activityName); | ||
| final @Nullable String appStartReason = AppStartMetrics.getInstance().getAppStartReason(); | ||
| if (appStartReason != null) { | ||
| appStartTransaction.setData(APP_START_REASON_DATA, appStartReason); | ||
| } | ||
| } | ||
|
|
||
| // Continue either the foreground app.start above or an earlier headless app.start. | ||
|
|
@@ -1002,6 +1008,10 @@ private void onHeadlessAppStart() { | |
| null); | ||
|
|
||
| final @NotNull ITransaction transaction = scopes.startTransaction(txnContext, txnOptions); | ||
| final @Nullable String appStartReason = metrics.getAppStartReason(); | ||
| if (appStartReason != null) { | ||
| transaction.setData(APP_START_REASON_DATA, appStartReason); | ||
| } | ||
| metrics.setAppStartTraceId(transaction.getSpanContext().getTraceId()); | ||
| // Persist trace headers so a later ui.load can share traceId and sampleRand. | ||
| metrics.setAppStartSentryTraceHeader(transaction.toSentryTrace().getValue()); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth mentioning that customers can search/group by this property in trace viewer? (they can, right?)