deps: bump radiance for mobile issue-report routing - #8985
Conversation
Picks up getlantern/radiance#603, which assembles mobile issue reports in the calling process rather than over IPC. Submitting a report from iOS while connected killed the tunnel: the archive was built entirely in memory inside the network extension, which runs under a fatal 50 MB jetsam cap. The extension was healthy at 31.25 MB one second before the submit; the log dir held 42 MB. The report failed, the tunnel dropped on its own, and a retry only worked because with the tunnel down the app assembled the archive instead. Assembling in the calling process means the app does that work, where the log dir is equally reachable through the shared App Group container and the memory ceiling is not 50 MB. engineering#3820
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the direct ChangesRadiance dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates the radiance dependency to route mobile issue-report assembly through the calling process; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the github.com/getlantern/radiance dependency to pick up upstream changes that route mobile issue-report assembly to the calling process (avoiding IPC-based archive assembly that can exceed iOS extension memory limits).
Changes:
- Bump
github.com/getlantern/radiancetov0.0.0-20260814190822-5559a4073bf3ingo.mod. - Update
go.sumto reflect the newradiancepseudo-version and checksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates required radiance version to include the upstream fix. |
| go.sum | Updates radiance module and go.mod checksums for the bumped version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Picks up getlantern/radiance#603 (merged) — mobile issue reports are assembled in the calling process rather than over IPC.
What this fixes
Submitting an issue report from the iOS app while connected killed the tunnel (engineering#3820). Reproduced twice on iPhone 16 / iOS 26.6:
The archive was built entirely in memory —
os.ReadFileper file into abytes.Bufferzip — inside a process with a fatal 50 MB jetsam cap. The log dir on that device held 42 MB (lantern.log26 MB,lantern_ios.log10 MB). The extension was healthy at 31.25 MB one second before the submit, so this was the archiver, not tunnel memory growth.Assembling in the calling process puts that work in the app, where the log dir is equally reachable through the shared App Group container and the ceiling is not 50 MB.
This was self-obscuring: you could not file a bug report from iOS while connected, which is exactly when users have something to report. Some earlier iOS submission failures attributed to network errors may have been this.
Scope
go.modonly — radiancef7470192fa1f→5559a4073bf3.go mod tidyrun before committing (nogo.sumchange needed beyond the module lines),go build ./...andgo vet ./lantern-core/...clean.Related
issue.gothenproto.Marshals the bytes, duplicating them again — but this bump removes the crash.🤖 Generated with Claude Code
https://claude.ai/code/session_01SkKS8hGeHM5g4BDPvxcamg
Summary by CodeRabbit