Skip to content

deps: bump radiance for mobile issue-report routing - #8985

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-issue-report-routing
Aug 14, 2026
Merged

myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-issue-report-routing

Conversation

@myleshorton

@myleshorton myleshorton commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Picks up getlantern/radiance#603 (merged) — mobile issue reports are assembled in the calling process rather than over IPC.

What this fixes

Submitting an issue report from the iOS app while connected killed the tunnel (engineering#3820). Reproduced twice on iPhone 16 / iOS 26.6:

16:43:15.578  extension healthy — footprint 31.25 MB, available 18.75 MB
16:43:16.142  POST /issue arrives
              ...per-second memory samples stop entirely...
16:43:16      app: Error reporting issue: ipc request POST /issue failed
16:43:21      Disconnecting / Disconnected      <-- unprompted
16:43:22      retry succeeds (tunnel down, so the app assembles the archive)

The archive was built entirely in memory — os.ReadFile per file into a bytes.Buffer zip — inside a process with a fatal 50 MB jetsam cap. The log dir on that device held 42 MB (lantern.log 26 MB, lantern_ios.log 10 MB). The extension was healthy at 31.25 MB one second before the submit, so this was the archiver, not tunnel memory growth.

Assembling in the calling process puts that work in the app, where the log dir is equally reachable through the shared App Group container and the ceiling is not 50 MB.

This was self-obscuring: you could not file a bug report from iOS while connected, which is exactly when users have something to report. Some earlier iOS submission failures attributed to network errors may have been this.

Scope

go.mod only — radiance f7470192fa1f5559a4073bf3. go mod tidy run before committing (no go.sum change needed beyond the module lines), go build ./... and go vet ./lantern-core/... clean.

Related

  • radiance#601 bounds what the archiver holds in memory regardless of which process runs it. Still worth having — the app should not read 42 MB either, and issue.go then proto.Marshals the bytes, duplicating them again — but this bump removes the crash.
  • Streaming the archive to a temp file instead of buffering remains the third piece.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SkKS8hGeHM5g4BDPvxcamg

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version.

Picks up getlantern/radiance#603, which assembles mobile issue reports in the
calling process rather than over IPC.

Submitting a report from iOS while connected killed the tunnel: the archive was
built entirely in memory inside the network extension, which runs under a fatal
50 MB jetsam cap. The extension was healthy at 31.25 MB one second before the
submit; the log dir held 42 MB. The report failed, the tunnel dropped on its
own, and a retry only worked because with the tunnel down the app assembled the
archive instead.

Assembling in the calling process means the app does that work, where the log
dir is equally reachable through the shared App Group container and the memory
ceiling is not 50 MB.

engineering#3820
Copilot AI lite review requested due to automatic review settings August 14, 2026 19:11
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 057f65d4-be3d-4183-ab49-55fe4eb0aebe

📥 Commits

Reviewing files that changed from the base of the PR and between 8ba1eb1 and bf191c3.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The pull request updates the direct github.com/getlantern/radiance dependency in go.mod to a newer pseudo-version.

Changes

Radiance dependency update

Layer / File(s) Summary
Update Radiance module requirement
go.mod
The github.com/getlantern/radiance requirement changes to pseudo-version v0.0.0-20260814190822-5559a4073bf3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bf191

This PR updates the radiance dependency to route mobile issue-report assembly through the calling process; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested reviewers: garmr-ulfr, jigar-f, wendelhime

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the Radiance dependency update and its purpose for mobile issue-report routing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fisk/bump-radiance-issue-report-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the github.com/getlantern/radiance dependency to pick up upstream changes that route mobile issue-report assembly to the calling process (avoiding IPC-based archive assembly that can exceed iOS extension memory limits).

Changes:

  • Bump github.com/getlantern/radiance to v0.0.0-20260814190822-5559a4073bf3 in go.mod.
  • Update go.sum to reflect the new radiance pseudo-version and checksums.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates required radiance version to include the upstream fix.
go.sum Updates radiance module and go.mod checksums for the bumped version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@myleshorton
myleshorton merged commit ef9397b into main Aug 14, 2026
11 checks passed
@myleshorton
myleshorton deleted the fisk/bump-radiance-issue-report-routing branch August 14, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants