Skip to content

Bump radiance for early start memory monitor changes - #8975

Merged
myleshorton merged 1 commit into
mainfrom
bump-radiance-start-memmon-immediately
Aug 12, 2026
Merged

myleshorton merged 1 commit into
mainfrom
bump-radiance-start-memmon-immediately

Conversation

@garmr-ulfr

@garmr-ulfr garmr-ulfr commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Pulls in the changes to the memory monitor lifecycle on mobile getlantern/radiance#597. The memory monitor now starts almost immediately when starting the tunnel in order to also monitor usage during initialization.

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version.

Copilot AI lite review requested due to automatic review settings August 12, 2026 19:52
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: be04861b-15b4-4b0a-a38f-b05ddd8c7991

📥 Commits

Reviewing files that changed from the base of the PR and between cc75aeb and a86ff5c.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The PR updates github.com/getlantern/radiance in go.mod from one pseudo-version to a newer pseudo-version. No exported declarations change.

Changes

Radiance dependency update

Layer / File(s) Summary
Update radiance version
go.mod
The github.com/getlantern/radiance dependency changes to a newer pseudo-version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: myleshorton, jigar-f

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the Radiance dependency update and its purpose of including early-start memory monitor changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-radiance-start-memmon-immediately

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the github.com/getlantern/radiance dependency to pull in mobile memory monitor lifecycle changes so monitoring starts earlier during tunnel startup (including initialization).

Changes:

  • Update github.com/getlantern/radiance to v0.0.0-20260812194443-f0277e466143
  • Refresh go.sum entries to match the updated module version/checksums

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Bumps the radiance module pseudo-version to include early-start memory monitor lifecycle changes.
go.sum Updates radiance module and go.mod checksums for the bumped version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@myleshorton
myleshorton merged commit cd9e202 into main Aug 12, 2026
11 checks passed
@myleshorton
myleshorton deleted the bump-radiance-start-memmon-immediately branch August 12, 2026 20:00
@myleshorton

Copy link
Copy Markdown
Contributor

Device-verified this pin (f0277e466143) on an iPhone 16 / iOS 26.6 — posting the numbers here since I built and tested the identical change in parallel before noticing this had already merged.

Release build from the pin (no local replace), per-second memory sampling from #8971:

build radiance peak steady teardown result
9.1.18 (baseline) 32–34 MB holds
#8974 dd149e2 35.92 MB 33.81 MB 37 ms holds
this (#8975) f0277e4 37.94 MB 32.77 MB 45 ms holds

54 samples, no jetsam, 17.2 MB headroom at plateau — the lowest steady-state of the three. Connect and user-initiated disconnect both clean:

PacketTunnelProvider stopping, reason: 1
(lantern-tunnel) stopping, reason: NEProviderStopReason(rawValue: 1)
(lantern-tunnel) stopTunnel completed in 0.045 seconds

For contrast, 9.1.19/9.1.20 reached the cap in under a second:

kernel: memorystatus: Tunnel exceeded mem limit: ActiveHard 50 MB (fatal)
ReportSystemMemory: killed by jetsam reason per-process-limit

Worth noting the startup-window point in radiance#597 matches what the captures showed: the extension was killed roughly a second after connecting, before the monitor's first tick, which is why memmon logged nothing on the failing builds and initially looked broken.

One thing I could not confirm from the device console: whether memmon now actually ticks during bring-up. Its ticks go to lantern.log on disk rather than os_log, so it would take a log bundle from the app to see them. The memory outcome above is unaffected either way.

Peak varies run to run (35.9 / 37.9 / 39.9 across builds) with which servers get probed; the plateau is the stable figure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants