harmonize desktop payment smoke tests - #8963
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Aligns the desktop payment smoke tests with the newer reusable “robot” structure and CI diagnostics, while keeping the staging E2E conversion flow intact for Windows/macOS smoke coverage.
Changes:
- Introduces a reusable
PaymentRobotto drive plan loading, plan selection, and checkout initiation through app state/providers. - Refactors the desktop Stripe checkout smoke test to use
AppRobot/PaymentRobotand stateful WebView trackers for clearer readiness/failure reporting. - Hardens CI workflows/scripts: prevent macOS smoke script from wiping local data outside CI and upload Windows payment smoke logs as artifacts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| integration_test/utils/payment_robot.dart | New reusable helper for plans + payment-method navigation and starting checkout flows. |
| integration_test/utils/app_robot.dart | Extends app-level robot for desktop readiness by dismissing macOS extension prompt during waits. |
| integration_test/payment/desktop_stripe_checkout_smoke_test.dart | Refactors smoke test to use robots and stateful WebView trackers; improves logging and run ID/email helpers. |
| .github/workflows/build-windows.yml | Uploads Windows payment smoke logs as an artifact for post-failure diagnosis. |
| .github/scripts/macos_payment_checkout_smoke.sh | Refuses to run outside CI to prevent accidental data deletion; uses marker file for staging selection and removes dart-define env override. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
59eb1c6
into
atavism/issue-3723-payment-conversion
* smoke(windows): verify Stripe checkout with Flutter * fix(smoke): use staging-capable lanternd * smoke(desktop): run Stripe checkout on macOS * smoke(macos): capture Stripe checkout screenshot * smoke(windows): verify checkout rendering from installed app * smoke(windows): verify staging checkout converts app to Pro * code review updates * code review updates * code review updates * code review updates * code review updates * code review updates * harmonize desktop payment smoke tests (#8963) * harmonize desktop payment smoke tests * code review updates * code review updates
Builds on #8939 by incorporating the reusable payment-test structure and CI improvements from @jigar-f’s #8960 while preserving the staging E2E conversion flow.