Skip to content

harmonize desktop payment smoke tests - #8963

Merged
atavism merged 2 commits into
atavism/issue-3723-payment-conversionfrom
atavism/issue-3723-payment-smoke-harmonization
Aug 10, 2026
Merged

harmonize desktop payment smoke tests#8963
atavism merged 2 commits into
atavism/issue-3723-payment-conversionfrom
atavism/issue-3723-payment-smoke-harmonization

Conversation

@atavism

@atavism atavism commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Builds on #8939 by incorporating the reusable payment-test structure and CI improvements from @jigar-f’s #8960 while preserving the staging E2E conversion flow.

  • Adds a reusable payment robot for Stripe rendering and conversion tests.
  • Improves state-based checkout tracking and desktop test readiness.
  • Prevents the macOS smoke script from deleting app data outside CI.
  • Captures Windows payment logs for easier failure diagnosis.

Copilot AI lite review requested due to automatic review settings August 10, 2026 19:03
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f16090c-37f4-40f2-8350-7df05f0de92b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the desktop payment smoke tests with the newer reusable “robot” structure and CI diagnostics, while keeping the staging E2E conversion flow intact for Windows/macOS smoke coverage.

Changes:

  • Introduces a reusable PaymentRobot to drive plan loading, plan selection, and checkout initiation through app state/providers.
  • Refactors the desktop Stripe checkout smoke test to use AppRobot/PaymentRobot and stateful WebView trackers for clearer readiness/failure reporting.
  • Hardens CI workflows/scripts: prevent macOS smoke script from wiping local data outside CI and upload Windows payment smoke logs as artifacts.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
integration_test/utils/payment_robot.dart New reusable helper for plans + payment-method navigation and starting checkout flows.
integration_test/utils/app_robot.dart Extends app-level robot for desktop readiness by dismissing macOS extension prompt during waits.
integration_test/payment/desktop_stripe_checkout_smoke_test.dart Refactors smoke test to use robots and stateful WebView trackers; improves logging and run ID/email helpers.
.github/workflows/build-windows.yml Uploads Windows payment smoke logs as an artifact for post-failure diagnosis.
.github/scripts/macos_payment_checkout_smoke.sh Refuses to run outside CI to prevent accidental data deletion; uses marker file for staging selection and removes dart-define env override.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread integration_test/utils/payment_robot.dart
@atavism
atavism merged commit 59eb1c6 into atavism/issue-3723-payment-conversion Aug 10, 2026
1 check passed
@atavism
atavism deleted the atavism/issue-3723-payment-smoke-harmonization branch August 10, 2026 19:11
atavism added a commit that referenced this pull request Aug 13, 2026
* smoke(windows): verify Stripe checkout with Flutter

* fix(smoke): use staging-capable lanternd

* smoke(desktop): run Stripe checkout on macOS

* smoke(macos): capture Stripe checkout screenshot

* smoke(windows): verify checkout rendering from installed app

* smoke(windows): verify staging checkout converts app to Pro

* code review updates

* code review updates

* code review updates

* code review updates

* code review updates

* code review updates

* harmonize desktop payment smoke tests (#8963)

* harmonize desktop payment smoke tests

* code review updates

* code review updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants