Harden Android test CI inputs

[atavism]

Safely validate and pass Firebase Test Lab entrypoints through the workflow and Make targets. Also prevent delayed available-server refreshes after Riverpod disposal, with regression coverage for the teardown race.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b855c050-5ec1-4442-ad36-6efd3c7dbf53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Ready to approve

The changes are narrowly scoped, add appropriate validation/guards, and include a targeted regression test for the disposal race.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR hardens the Android Firebase Test Lab CI path by validating untrusted workflow inputs before forwarding them into Make/Gradle, and fixes a Riverpod teardown race where AvailableServersNotifier could attempt a delayed refresh after disposal (now covered by a regression test).

Changes:

• Add bash-side validation for inputs.test_target in the Firebase Test Lab workflow before invoking Make.
• Quote -Ptarget usage in Makefile Android integration targets to avoid argument splitting.
• Prevent post-disposal refresh work in AvailableServersNotifier, with a regression test covering disposal during the first fetch.

File summaries

File	Description
test/features/vpn/provider/available_servers_notifier_test.dart	Adds a regression test to ensure probe-settle refresh completes cleanly when disposed mid-fetch.
Makefile	Quotes -Ptarget when calling Gradle for Android integration test targets.
lib/features/vpn/provider/available_servers_notifier.dart	Adds ref.mounted guards to stop refresh work after provider disposal.
.github/workflows/firebase-test-lab.yml	Validates and safely forwards ANDROID_INTEGRATION_TARGET from workflow inputs.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.