Unified Share My Connection screen with globe, Advanced section, and Unbounded as Basic mode (Part 1/2)

[myleshorton]

Summary

End-to-end UX for Share My Connection — one unified screen, one toggle, one globe — with both donor modes wired through:

• Full mode (SmC): samizdat over UPnP / manual-port forwarding; persistent residential exit.
• Basic mode (Unbounded): broflake / WebRTC ephemeral peer sessions.

The user picks between modes via a one-time disclosure dialog. Both protocols emit identically-shaped EventTypePeerConnection FlutterEvents that the globe consumes — protocol-agnostic rendering.

This is Part 1 of 2 of the original #8740 split. Part 2 ships Unbounded as a top-level home tab in a follow-up.

What's in this PR

Screen (lib/features/share_my_connection/share_my_connection.dart):

• Replaces the inline SmC toggle in vpn_setting.dart with a navigation tile to a dedicated screen.
• Globe (Jigar's flutter_earth_globe integration from Unbounded changes #8493, reused verbatim, MediaQuery-overridden to centre in-widget).
• Status card with mode badge + active/total counters.
• One-time SmC disclosure dialog ("Full mode" / "Basic mode").
• Advanced section (collapsed by default): manual port-forward field for users on UPnP-less networks; persists via setPeerManualPort FFI, takes effect on next toggle-on.
• Per-peer geolocation rendering on the globe + arc reversal.
• Lottie heart-burst toast on remote-client arrival, lifted off the globe so it's not clipped by viewport bounds.

Backend (Go, lantern-core/):

• Core.SetPeerManualPort / GetPeerManualPort → PatchSettings(PeerManualPortKey: int).
• Core.SetUnboundedEnabled / IsUnboundedEnabled → PatchSettings(UnboundedKey: bool).
• listenPeerConnectionEvents subscribes to both peer.ConnectionEvent (samizdat) and unbounded.ConnectionEvent (broflake), forwards as one EventTypePeerConnection FlutterEvent — globe is protocol-agnostic.
• 4 new //export FFI functions: setPeerManualPort, getPeerManualPort, setUnboundedEnabled, isUnboundedEnabled.
• Mobile error sanitization before returning to gomobile bridge (prevents "object" leakage into Flutter logs).
• Consumes peer events over IPC SSE instead of in-process events.Subscribe — same wire format as the rest of the FlutterEvent bridge.

Frontend (Dart):

• Hand-rolled FFI bindings for the 4 new exports.
• LanternCoreService interface, FFI impl, Service router, Platform stub all gain the new methods. Platform stub returns "not implemented" — iOS / Android MethodChannel handlers aren't plumbed yet (degrades gracefully).
• macOS native handler routes the new MethodChannel calls into Go.

End-to-end event flow

sequenceDiagram
    autonumber
    participant UI as SmC toggle
    participant FFI as lantern-core FFI
    participant Core as LanternCore
    participant Backend as radiance Backend
    participant Mode as peer/unbounded
    participant Bus as radiance events
    participant Globe as Flutter globe

    UI->>FFI: setPeerProxyEnabled(1) | setUnboundedEnabled(1)
    FFI->>Core: SetPeerShareEnabled | SetUnboundedEnabled
    Core->>Backend: PatchSettings(...)
    Note over Backend: applyPeerShare → peer.Client.Start<br/>or unbounded.shouldRun re-evaluates
    Backend->>Mode: Start
    loop each remote client
        Mode->>Bus: events.Emit(ConnectionEvent{...})
    end
    Bus->>Core: listenPeerConnectionEvents (subscribes to BOTH)
    Core->>FFI: notifyFlutter(EventTypePeerConnection, json)
    FFI->>Globe: dart_api_dl.SendToPort(appEventPort, ...)
    Globe->>Globe: appEvents stream → arc + heart-burst renders

Loading

How this was sliced

Cherry-picked from the original fisk/share-my-connection-ux (#8740) — the chronological first 21 commits. The second half (Unbounded as a top-level home tab + auto-enable + final polish) lands as the stacked follow-up.

Test plan

• flutter analyze clean.
• go build ./lantern-core/... clean.
• macOS end-to-end (requires make macos-release after merging the dependent radiance PRs):
  • Settings → VPN → Share my connection.
  • Toggle on → take "Full mode (SmC)" → real peer.Client.Start runs (UPnP map → lantern-cloud register → verify → samizdat inbound).
  • Toggle on → take "Basic mode (Unbounded)" → broflake widget-proxy runs.
  • Toggle off, on, on/off cycle without leaks.
  • Advanced → set manual port = 5698 → toggle on → port forwarder uses manual mapping, skips UPnP probe.

Dependencies

• Add peer-share toggle to lantern-core (Share My Connection PR 3/4) #8729 (peer-share toggle in lantern-core, PR 3/4) — content duplicated into this branch; drops out once merged to main.
• Wire Share My Connection toggle in Dart UI (PR 4/4) #8730 (Wire SmC toggle in Dart UI, PR 4/4) — same.
• radiance peer: stream samizdat ConnectionEvents through radiance to consumers radiance#499 (peer ConnectionEvents + IPC streaming) — foundational for the event flow.
• radiance peer: manual port-forward override for UPnP-less networks radiance#500 (manual port-forward override) — needed for the Advanced section.
• radiance unbounded: WebRTC widget-proxy integration as a parallel peer source radiance#501 (Unbounded broflake integration) — needed for Basic mode.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added Share My Connection, including Unbounded mode and peer connection sharing.
  • Added connection status, activity counts, peer arrival notifications, and globe visualizations.
  • Added manual port configuration, validation, UPnP probing, and fallback behavior.
  • Added platform support for enabling, disabling, and checking sharing settings.
• Bug Fixes
  • Improved error handling and reliability when configuring connections or communicating across platforms.
• Style
  • Added new animations and localized interface text for sharing workflows.

[Copilot]

Pull request overview

Part 1/2 of the unified Share My Connection UX. Adds a dedicated screen with a rotating globe, a one-time disclosure dialog gating Full mode (samizdat-over-UPnP / SmC) vs Basic mode (Unbounded / broflake), and an Advanced section for a manual port-forward override. Wires four new FFI/MethodChannel surfaces (setPeerProxyEnabled, setPeerManualPort, setUnboundedEnabled, plus is* getters) through the Go FFI/mobile layers, the Dart service layers, macOS Swift handler, and a new radianceSettingsProvider.peerProxy field. Introduces a unified EventTypePeerConnection/EventTypePeerStatus FlutterEvent stream so the globe is protocol-agnostic, and sanitizes Go errors crossing gomobile to prevent invalid-UTF-8 crashes.

Changes:

• New ShareMyConnectionScreen with globe, status card, Advanced manual-port field, SmC disclosure dialog, and Lottie heart-burst arrival toast.
• New Go Core.{SetPeerShareEnabled, SetPeerManualPort, SetUnboundedEnabled, …} + FFI exports + mobile bindings + macOS MethodChannel handlers; listenPeerConnectionEvents/listenPeerStatusEvents bridge radiance events to Flutter.
• RadianceSettingsState.peerProxy, RadianceSettings.setPeerProxy, gomobile sanitizeForGomobile for UTF-8/empty error normalization, new GeoLookupService, UnboundedConnectionEvent model, flutter_earth_globe/lottie/http deps, Lottie explosion + locale strings.

Reviewed changes

Copilot reviewed 20 out of 24 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
lib/features/share_my_connection/share_my_connection.dart	New unified SmC screen with globe, disclosure, Advanced port field, arrival toast.
lib/features/setting/vpn_setting.dart	Replaces inline SmC toggle with navigation tile to new screen (desktop only).
lib/features/home/provider/radiance_settings_providers.dart	Adds peerProxy field/setter to settings provider; conditional load by platform.
lib/core/models/radiance_settings_state.dart	Adds peerProxy to state, copyWith, equality, hashCode.
lib/core/models/unbounded_connection_event.dart	New model representing peer connection events with geo fields.
lib/core/services/geo_lookup_service.dart	New geo lookup service (self via geo.getiantem.org, peers via ipwho.is).
lib/lantern/lantern_core_service.dart	Adds peer-proxy / manual-port / unbounded methods to interface.
lib/lantern/lantern_ffi_service.dart	FFI implementations for the six new methods.
lib/lantern/lantern_platform_service.dart	MethodChannel implementations for the six new methods.
lib/lantern/lantern_service.dart	Routes new methods to FFI or platform service per platform.
lib/lantern/lantern_generated_bindings.dart	Hand-added native bindings for four new C exports.
macos/Runner/Handlers/MethodHandler.swift	macOS routing of new MethodChannel calls into Mobile* Go binds.
lantern-core/core.go	New PeerShare interface, settings get/set, event bridges for peer/unbounded.
lantern-core/ffi/ffi.go	New //export C functions for peer / unbounded / manual-port settings.
lantern-core/mobile/mobile.go	gomobile-bound wrappers around the new Core methods.
lantern-core/utils/gostack.go	Sanitizes errors for gomobile to ensure non-empty valid UTF-8 messages.
pubspec.yaml / pubspec.lock	Adds flutter_earth_globe, lottie, http deps and assets/unbounded/.
go.mod / go.sum	Bumps radiance and related deps; drops local replace directives.
assets/locales/en.po	Adds share_my_connection / share_my_connection_subtitle strings.
assets/unbounded/explosion.json	Lottie animation asset for arrival toast burst.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 6 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 3 comments.

[myleshorton]

Pushing back: tests would be valuable here, but I'd rather add them after #8820 (Part 2/2) lands than now. #8820 substantially rewrites ShareNotifier.toggle's mode-selection (auto-enable path becomes Unbounded-only, the screen becomes a tab embed rather than a navigated screen, the welcome dialog and Unbounded settings get introduced, _fallbackToUnbounded lands). Tests written against the #8819-only surface would need to be largely rewritten 24 hours later.

Tracking this as a follow-up task to land alongside #8820 — _extractIP is the cleanest immediate test target since its surface is fixed; toggle and _handlePeerStatus should wait until the Part 2 lifecycle is in place.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 26 changed files in this pull request and generated 4 comments.

[teamlantern]

This PR has been inactive for 30 days.

Waiting on: none

It will be closed automatically in 7 days if no action is taken.

[teamlantern]

This PR has been inactive for 31 days.

Waiting on: none

It will be closed automatically in 7 days if no action is taken.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds Share My Connection and Unbounded controls across LanternCore, native bridges, Dart services, and Flutter UI. It adds peer event forwarding, UPnP probing, manual-port configuration, geo lookup, connection visualization, localization, and animation assets.

Changes

Share My Connection

Layer / File(s)	Summary
Core peer contracts and events lantern-core/core.go	LanternCore exposes peer-sharing settings, manual-port validation, UPnP probing, Unbounded controls, and peer connection/status events.
Native mobile and platform bridge lantern-core/mobile/mobile.go, lantern-core/ffi/ffi.go, android/..., ios/..., macos/..., lantern-core/utils/gostack.go	Native APIs and method channels support peer proxying, manual ports, Unbounded mode, and UPnP probing. Gomobile errors are normalized before crossing the bridge.
Dart service API wiring lib/lantern/*	Dart services route the new operations through FFI or MethodChannel implementations and convert results to typed failures or values.
Flutter state and connection data lib/core/models/*, lib/core/services/geo_lookup_service.dart, lib/features/home/provider/*, lib/features/setting/vpn_setting.dart	Settings, Unbounded events, geo results, provider state, and VPN settings now represent Share My Connection state.
Share My Connection flow and presentation lib/features/share_my_connection/*, assets/locales/en.po, assets/unbounded/*, pubspec.yaml, go.mod	The new screen manages sharing modes, lifecycle states, peer visualization, notifications, manual-port settings, disclosure content, localization, animation assets, and dependency updates.

Estimated code review effort: 5 (Critical) | ~120 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ShareMyConnectionScreen
  participant ShareNotifier
  participant LanternService
  participant LanternCore
  participant PeerEvents
  ShareMyConnectionScreen->>ShareNotifier: enable sharing
  ShareNotifier->>LanternService: probeUPnP and set sharing mode
  LanternService->>LanternCore: invoke peer-sharing or Unbounded API
  PeerEvents->>LanternCore: deliver connection and status events
  LanternCore->>ShareNotifier: emit peer event payloads
  ShareNotifier->>ShareMyConnectionScreen: update counts, globe, and notifications

Loading

Possibly related issues

• getlantern/engineering#3221 — Covers the Flutter/native Share My Connection toggle, UPnP probing, manual ports, and peer-proxy lifecycle implemented here.

Possibly related PRs

• getlantern/lantern#8729 — Adds the related peer-share toggle wiring in the same core, FFI, and mobile API layers.

Suggested reviewers: copilot, garmr-ulfr

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 41.18% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the unified Share My Connection screen and its main globe, Advanced section, and Unbounded Basic mode changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fisk/smc-unified-screen

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Copilot reviewed 21 out of 29 changed files in this pull request and generated no new comments.

Files not reviewed (3)

• lib/features/home/provider/home_notifier.g.dart: Generated file
• lib/features/home/provider/radiance_settings_providers.g.dart: Generated file
• lib/features/vpn/provider/available_servers_notifier.g.dart: Generated file

Suppressed comments (4)

lib/features/share_my_connection/share_my_connection.dart:221

• ShareNotifier always initializes to const ShareState() and never reconciles with persisted backend settings (peer proxy / Unbounded). After an app restart (or if the setting is enabled outside this screen), this screen can render as Off and the toggle path will try to enable again instead of allowing the user to disable an already-running share session.

Consider bootstrapping state from LanternCoreService.isPeerProxyEnabled() / isUnboundedEnabled() (or the already-refreshed radianceSettingsProvider state) and starting the app-event subscription when either is already enabled so the UI reflects actual runtime state.

    ref.onDispose(() {
      _stopEventSubscription();
      _eventController.close();
    });
    return const ShareState();

lib/core/services/geo_lookup_service.dart:206

• peerLookup() sends peers' source IP addresses to ipwho.is (third-party). Even with caching, this is a new external data flow for potentially sensitive user IPs and can also become an availability risk if that endpoint is blocked/slow (5s timeout) in some regions.

Before shipping broadly, consider gating this behind an explicit user consent/feature flag, or proxying through a Lantern-controlled endpoint / local DB so peer IPs aren’t shared with a third party.

  /// Privacy note: each call ships [ip] — the address of a peer routing
  /// through this user's Share My Connection inbound — to ipwho.is, a
  /// third-party geo-IP service. For most SmC consumers these are
  /// censored users' addresses, so this is an outbound data flow to a
  /// non-Lantern endpoint. Current rationale for accepting it: the IP

lib/features/setting/vpn_setting.dart:158

• This screen navigation uses Navigator.push(MaterialPageRoute(...)), but the rest of this settings screen consistently navigates via appRouter.push(...) (auto_route). Using a raw MaterialPageRoute here makes routing/deeplinks/analytics inconsistent and is harder to refactor later.

Prefer adding ShareMyConnection to the app router (@RoutePage + route entry) and pushing it via appRouter.push(...).

              onPressed: () {
                Navigator.of(context).push(
                  MaterialPageRoute(
                    builder: (_) => const ShareMyConnectionScreen(),
                  ),

lib/features/share_my_connection/share_my_connection.dart:404

• _stop() cancels the app-event subscription and resets UI state before verifying that the underlying disable call succeeded, and it also ignores the returned Either. If the IPC/MethodChannel call fails, the UI will show sharing as Off and the globe arcs are cleared even though the backend setting may still be enabled.

  Future<void> _stop(WidgetRef widgetRef) async {
    _stopEventSubscription();
    final priorMode = state.mode;
    state = const ShareState();
    switch (priorMode) {

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (6)

lib/features/setting/vpn_setting.dart (1)

154-160: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use appRouter for this navigation.

Every other tile in this file pushes through appRouter. This card uses Navigator.of(context).push with a raw MaterialPageRoute, so ShareMyConnectionScreen stays outside the AutoRoute graph and cannot be targeted by a route name or deep link. Register the screen as a route and push it through appRouter for consistency.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/setting/vpn_setting.dart` around lines 154 - 160, Update the
navigation callback for ShareMyConnectionScreen to use the existing appRouter
instead of Navigator.of(context) with a raw MaterialPageRoute. Register
ShareMyConnectionScreen in the AutoRoute configuration and navigate to its
generated route so it remains addressable by route name and deep links, matching
the other tiles in this file.

lib/core/services/geo_lookup_service.dart (2)

44-47: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Bound the per-IP cache.

_peerCache grows for the process lifetime with one entry per distinct peer IP. A host that shares for a long period serves many distinct clients, so the map has no upper bound. Cap it with a small LRU or evict on _stopEventSubscription to keep memory predictable.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/core/services/geo_lookup_service.dart` around lines 44 - 47, Bound the
lifetime and size of the static _peerCache used by GeoLookupService. Update the
cache access logic to enforce a small LRU limit, refreshing entries on reuse and
evicting the least-recently-used entries when the limit is exceeded; preserve
resetCacheForTest behavior and ensure any existing _stopEventSubscription
cleanup also clears the cache where appropriate.

---

222-224: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Encode the IP as a path segment.

ip reaches this line from _extractIP, which returns the input unchanged when it contains no colon. Any unexpected character then lands unencoded in the request path. Build the URI from path segments so the request shape stays fixed.

♻️ Proposed change

-      final response = await http
-          .get(Uri.parse('$_peerUrl/$ip'))
-          .timeout(const Duration(seconds: 5));
+      final response = await http
+          .get(Uri.parse(_peerUrl).replace(pathSegments: [ip]))
+          .timeout(const Duration(seconds: 5));

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/core/services/geo_lookup_service.dart` around lines 222 - 224, Update the
request construction in the geo lookup method around _extractIP so the IP value
is encoded as a URI path segment rather than interpolated directly into the URL
string. Preserve the existing peer URL, IP, timeout, and HTTP GET behavior while
building the URI with path-segment APIs.

lib/features/share_my_connection/share_my_connection.dart (1)

418-423: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Cancel the previous subscription before assigning a new one.

_startEventSubscription overwrites _appEventSub without cancelling it. If _start runs twice without an intervening _stopEventSubscription, the old subscription stays active, every peer event is handled twice, and activeCount double-counts.

🛡️ Proposed guard

   void _startEventSubscription(WidgetRef widgetRef) {
+    _appEventSub?.cancel();
     _peerArcs.clear();
     _appEventSub = widgetRef
         .read(lanternServiceProvider)
         .watchAppEvents()
         .listen((event) {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/share_my_connection/share_my_connection.dart` around lines 418 -
423, Update _startEventSubscription to cancel the existing _appEventSub before
creating and assigning the new watchAppEvents subscription, ensuring repeated
starts leave only one active listener and prevent duplicate peer-event handling.

assets/locales/en.po (1)

665-666: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Rename the key to match the text.

The key says total_today but the text says "Total this session". ShareState.totalCount resets on each toggle, so the text is correct and the key is misleading for translators. Rename the key to smc_stat_total_session and update the call site in lib/features/share_my_connection/share_my_connection.dart line 784.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@assets/locales/en.po` around lines 665 - 666, Rename the locale key from
smc_stat_total_today to smc_stat_total_session in the English translation and
update the corresponding lookup in ShareState’s call site within
share_my_connection.dart, preserving the existing “Total this session” text.

lib/core/models/unbounded_connection_event.dart (1)

42-48: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove unused UnboundedStats.

No Dart file references UnboundedStats; the active/count values live in ShareState, so remove this competing count model unless a consumer is added.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/core/models/unbounded_connection_event.dart` around lines 42 - 48, Remove
the unused UnboundedStats class and its activeCount/totalCount fields from the
model file, since connection counts are maintained by ShareState and no
consumers reference this competing model.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lantern-core/ffi/ffi.go`:
- Around line 1423-1430: Update the int-returning exports that call requireCore—
including isPeerProxyEnabled, getPeerManualPort, probeUPnP, and
isUnboundedEnabled—so the unused error C string is freed whenever returned, or
switch these getter paths to the allocation-free loadCore helper. Preserve each
export’s existing return behavior.

In `@lib/features/setting/vpn_setting.dart`:
- Around line 73-94: Move the unconditional DividerSpace() following the routing
block into the !PlatformUtils.isIOS block in the settings widget, placing it
after SplitTunnelingTile’s routing tile so it only separates existing tiles.
Remove the standalone divider to prevent trailing dividers on iOS and Linux.

In `@lib/features/share_my_connection/share_my_connection.dart`:
- Around line 1358-1371: Update the TextField itself to bind its enabled state
to loaded.value && !saving.value, and remove the same enabled setting from
InputDecoration. Keep the existing label, hint, border, and input configuration
unchanged.

---

Nitpick comments:
In `@assets/locales/en.po`:
- Around line 665-666: Rename the locale key from smc_stat_total_today to
smc_stat_total_session in the English translation and update the corresponding
lookup in ShareState’s call site within share_my_connection.dart, preserving the
existing “Total this session” text.

In `@lib/core/models/unbounded_connection_event.dart`:
- Around line 42-48: Remove the unused UnboundedStats class and its
activeCount/totalCount fields from the model file, since connection counts are
maintained by ShareState and no consumers reference this competing model.

In `@lib/core/services/geo_lookup_service.dart`:
- Around line 44-47: Bound the lifetime and size of the static _peerCache used
by GeoLookupService. Update the cache access logic to enforce a small LRU limit,
refreshing entries on reuse and evicting the least-recently-used entries when
the limit is exceeded; preserve resetCacheForTest behavior and ensure any
existing _stopEventSubscription cleanup also clears the cache where appropriate.
- Around line 222-224: Update the request construction in the geo lookup method
around _extractIP so the IP value is encoded as a URI path segment rather than
interpolated directly into the URL string. Preserve the existing peer URL, IP,
timeout, and HTTP GET behavior while building the URI with path-segment APIs.

In `@lib/features/setting/vpn_setting.dart`:
- Around line 154-160: Update the navigation callback for
ShareMyConnectionScreen to use the existing appRouter instead of
Navigator.of(context) with a raw MaterialPageRoute. Register
ShareMyConnectionScreen in the AutoRoute configuration and navigate to its
generated route so it remains addressable by route name and deep links, matching
the other tiles in this file.

In `@lib/features/share_my_connection/share_my_connection.dart`:
- Around line 418-423: Update _startEventSubscription to cancel the existing
_appEventSub before creating and assigning the new watchAppEvents subscription,
ensuring repeated starts leave only one active listener and prevent duplicate
peer-event handling.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 43260372-cb40-4689-97ef-56a9d265fded

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9af4a and 8c9cdb3.

⛔ Files ignored due to path filters (4)

• assets/unbounded/uv-map-dark.png is excluded by !**/*.png
• assets/unbounded/uv-map.png is excluded by !**/*.png
• go.sum is excluded by !**/*.sum
• pubspec.lock is excluded by !**/*.lock

📒 Files selected for processing (25)

• android/app/src/main/kotlin/org/getlantern/lantern/handler/MethodHandler.kt
• assets/locales/en.po
• assets/unbounded/explosion.json
• go.mod
• ios/Runner/Handlers/MethodHandler.swift
• lantern-core/core.go
• lantern-core/ffi/ffi.go
• lantern-core/mobile/mobile.go
• lantern-core/utils/gostack.go
• lib/core/models/radiance_settings_state.dart
• lib/core/models/unbounded_connection_event.dart
• lib/core/services/geo_lookup_service.dart
• lib/features/home/provider/home_notifier.g.dart
• lib/features/home/provider/radiance_settings_providers.dart
• lib/features/home/provider/radiance_settings_providers.g.dart
• lib/features/setting/vpn_setting.dart
• lib/features/share_my_connection/share_my_connection.dart
• lib/features/vpn/provider/available_servers_notifier.g.dart
• lib/lantern/lantern_core_service.dart
• lib/lantern/lantern_ffi_service.dart
• lib/lantern/lantern_generated_bindings.dart
• lib/lantern/lantern_platform_service.dart
• lib/lantern/lantern_service.dart
• macos/Runner/Handlers/MethodHandler.swift
• pubspec.yaml

[coderabbitai]

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find every export that discards the requireCore error string.
set -euo pipefail

rg -n -B 3 -A 3 'requireCore\(\)' lantern-core/ffi/ffi.go
rg -n -C 4 'func freeCString' lantern-core/ffi/ffi.go

Repository: getlantern/lantern

Length of output: 17201

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== ffi.go requireCore definition and callers == "
sed -n '55,70p;1418,1511p' lantern-core/ffi/ffi.go

echo "== Dart uses of requireCore caller-like symbols? =="
rg -n "isPeerProxyEnabled|getPeerManualPort|probeUPnP|isUnboundedEnabled|isTelemetryEnabled|isOAuthLogin|isSplitTunnelingEnabled|isVPNConnected|isBlockAdsEnabled|isSmartRoutingEnabled" .

Repository: getlantern/lantern

Length of output: 29050

---

Free the unused error string returned by requireCore.

requireCore allocates a C string when the core is unavailable. Int-returning exports discard that pointer with c, _ := requireCore(), including isPeerProxyEnabled, getPeerManualPort, probeUPnP, and isUnboundedEnabled. Free the pointer, or use an allocation-free loadCore() helper for these getters.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lantern-core/ffi/ffi.go` around lines 1423 - 1430, Update the int-returning
exports that call requireCore— including isPeerProxyEnabled, getPeerManualPort,
probeUPnP, and isUnboundedEnabled—so the unused error C string is freed whenever
returned, or switch these getter paths to the allocation-free loadCore helper.
Preserve each export’s existing return behavior.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

A trailing divider renders on iOS and Linux.

DividerSpace() at line 82 is now unconditional, but both surrounding blocks are platform-gated.

• On iOS the routing block is skipped and the split-tunneling block is skipped, so the card ends with server_locations followed by a divider.
• On Linux the split-tunneling condition excludes the platform, so the card ends with the routing tile followed by a divider.

Move the divider into the leading block so it only renders between tiles.

🐛 Proposed fix

               if (!PlatformUtils.isIOS) ...[
                 DividerSpace(),
                 SplitTunnelingTile(
                   label: 'routing_mode'.i18n,
                   icon: AppImagePaths.route,
                   actionText: routingMode.label(),
                   onPressed: () => appRouter.push(const SmartRouting()),
                 ),
               ],
-              DividerSpace(),
               if (PlatformUtils.isAndroid ||
                   PlatformUtils.isMacOS ||
                   PlatformUtils.isWindows) ...[
+                DividerSpace(),
                 SplitTunnelingTile(
                   label: 'split_tunneling'.i18n,
                   icon: AppImagePaths.callSpilt,
                   actionText:
                       splitTunnelingEnabled ? 'enabled'.i18n : 'disabled'.i18n,
                   onPressed: () => appRouter.push(const SplitTunneling()),
                 ),
-                DividerSpace(),
               ],

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	if (!PlatformUtils.isIOS) ...[
	DividerSpace(),
	SplitTunnelingTile(
	label: 'routing_mode'.i18n,
	icon: AppImagePaths.route,
	actionText: routingMode.label(),
	onPressed: () => appRouter.push(const SmartRouting()),
	)
	},
	),
	],
	DividerSpace(),
	if (PlatformUtils.isAndroid ||
	PlatformUtils.isMacOS ||
	PlatformUtils.isWindows) ...{
	PlatformUtils.isWindows) ...[
	SplitTunnelingTile(
	label: 'split_tunneling'.i18n,
	icon: AppImagePaths.callSpilt,
	actionText:
	splitTunnelingEnabled ? 'enabled'.i18n : 'disabled'.i18n,
	onPressed: () => appRouter.push(const SplitTunneling()),
	),
	DividerSpace()
	},
	DividerSpace(),
	],
	if (!PlatformUtils.isIOS) ...[
	DividerSpace(),
	SplitTunnelingTile(
	label: 'routing_mode'.i18n,
	icon: AppImagePaths.route,
	actionText: routingMode.label(),
	onPressed: () => appRouter.push(const SmartRouting()),
	),
	],
	if (PlatformUtils.isAndroid ||
	PlatformUtils.isMacOS ||
	PlatformUtils.isWindows) ...[
	DividerSpace(),
	SplitTunnelingTile(
	label: 'split_tunneling'.i18n,
	icon: AppImagePaths.callSpilt,
	actionText:
	splitTunnelingEnabled ? 'enabled'.i18n : 'disabled'.i18n,
	onPressed: () => appRouter.push(const SplitTunneling()),
	),
	],

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/setting/vpn_setting.dart` around lines 73 - 94, Move the
unconditional DividerSpace() following the routing block into the
!PlatformUtils.isIOS block in the settings widget, placing it after
SplitTunnelingTile’s routing tile so it only separates existing tiles. Remove
the standalone divider to prevent trailing dividers on iOS and Linux.

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

Flutter InputDecoration enabled property versus TextField enabled property difference

💡 Result:

In Flutter, the enabled property on a TextField (or TextFormField) and the enabled property on an InputDecoration serve different purposes, with the TextField's property acting as the primary control for interaction [1][2]. 1. TextField.enabled: This property controls the overall interactivity of the text field [1]. When set to false, the text field is "disabled": it ignores all user input (taps, typing, etc.) [1][2]. Additionally, it overrides the enabled property found within the InputDecoration [1]. When a TextField is disabled, its entire UI, including its decoration and children like the suffixIcon, will appear disabled (usually rendered in grey or with reduced opacity) and become non-interactive [1][3]. 2. InputDecoration.enabled: This property is purely visual and defines the state of the decoration itself [4][5]. When set to false, it reduces the opacity of visual elements like the helperText, errorText, and counterText [4]. It does not disable user interaction with the text field itself [1]. In practice, because TextField.enabled overrides this property when provided, the InputDecoration.enabled property is primarily managed automatically by the parent TextField based on its own state [1]. Key Distinction: If you want to make a text field non-editable but keep its contents (like a suffix icon) interactive, setting TextField.enabled to false will not work because it disables the entire widget [1][3]. Instead, you should keep the TextField enabled (set to true) and use the readOnly property combined with enableInteractiveSelection: false [1][3]. This allows the field to appear as if it is in a read-only state while ensuring that buttons within the decoration remain clickable [1].

Citations:

• 1: https://api.flutter.dev/flutter/material/TextField/enabled.html
• 2: https://api.flutter.dev/flutter/material/TextField-class.html
• 3: [docs] InputDecoration.enabled should explain how it interacts with suffixIcon flutter/flutter#167713
• 4: https://api.flutter.dev/flutter/material/InputDecoration-class.html
• 5: https://main-api.flutter.dev/flutter/material/InputDecoration-class.html

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="lib/features/share_my_connection/share_my_connection.dart"

echo "== file exists and line count =="
test -f "$file" && wc -l "$file"

echo "== relevant TextField section (1348-1380) =="
sed -n '1348,1380p' "$file" | cat -n

echo "== relevant context lines around 1320-1344 =="
sed -n '1320,1344p' "$file" | cat -n

echo "== controller and onChanged usages =="
rg -n "controller:|onChanged|loaded\.value|saving\.value|load|load.*port|port.*load" "$file" | sed -n '1,120p'

echo "== Flutter docs excerpts if local cache/dependency is unavailable check package api =="
python3 - <<'PY'
from pathlib import Path
candidates=[]
for p in Path('.').rglob('text_field.dart'):
    if 'flutter/packages/flutter/lib/src/material/text_field.dart' in str(p):
        candidates.append(str(p))
print("local flutter text_field.dart:", candidates[:3])
PY

Repository: getlantern/lantern

Length of output: 4268

---

🌐 Web query:

Flutter TextEditingController text assignment listener called isSettable

💡 Result:

In Flutter, when you assign a new string to the text property of a TextEditingController, it triggers all registered listeners [1]. There is no property or parameter named isSettable in the TextEditingController class; the term is likely a misunderstanding or confusion with the isSetter property found in other parts of the Dart language (such as in the Invocation or reflection libraries) [2][3][4]. Key technical points regarding TextEditingController text assignment: 1. Listener Notification: Setting the text property updates the controller's value and calls notifyListeners [1]. This ensures that any component observing the controller (via addListener) is notified of the change [5][6]. 2. Distinction from onChanged: Note that assigning a value to controller.text does not trigger the TextField's own onChanged callback [7][8]. The onChanged callback is specifically designed to report user-initiated changes (e.g., typing via the keyboard) [7][8]. Programmatic updates via the controller are intended to be managed by the developer directly [8]. 3. Best Practices: - Setting the text property causes listeners to fire synchronously [9]. You should avoid setting the text property during the build, layout, or paint phases, as this can lead to errors or performance issues [1]. - If you need to perform actions when the text changes—whether initiated by the user or programmatically—the recommended approach is to add a listener to the controller using addListener [6][8]. There is no native framework mechanism or configuration property called isSettable that controls whether listeners are called during text assignment [1][5]. Any time the text value is updated, the associated listeners will be notified [1][10].

Citations:

• 1: https://api.flutter.dev/flutter/widgets/TextEditingController/text.html
• 2: https://api.flutter.dev/flutter/vm_service/Func/isSetter.html
• 3: https://api.dart.dev/dart-core/Invocation/isSetter.html
• 4: https://pub.dev/documentation/reflectable/latest/reflectable.mirrors/MethodMirror-class.html
• 5: https://api.flutter.dev/flutter/widgets/TextEditingController-class.html
• 6: https://docs.flutter.dev/cookbook/forms/text-field-changes
• 7: TextField callback onChanged not fired when its controller.text is set flutter/flutter#25373
• 8: https://api.flutter.dev/flutter/material/TextField/onChanged.html
• 9: TextEditingController.text docs miss a reason flutter/flutter#46728
• 10: https://api.flutter.dev/flutter/widgets/TextEditingController/value.html

---

Disable the TextField instead of only its decoration.

InputDecoration.enabled changes styling; it does not prevent typing. When loaded.value is false or saving.value is true, set TextField.enabled so user input cannot change the controller value that may later be overwritten by the persisted port load.

🐛 Proposed fix

               child: TextField(
                 controller: controller,
+                enabled: loaded.value && !saving.value,
                 keyboardType: const TextInputType.numberWithOptions(
                   decimal: false,
                   signed: false,
                 ),
                 decoration: InputDecoration(
                   labelText: 'smc_manual_port_label'.i18n,
                   hintText: 'smc_manual_port_hint'.i18n,
                   border: const OutlineInputBorder(),
                   isDense: true,
-                  enabled: loaded.value && !saving.value,
                 ),
               ),

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	child: TextField(
	controller: controller,
	keyboardType: const TextInputType.numberWithOptions(
	decimal: false,
	signed: false,
	),
	decoration: InputDecoration(
	labelText: 'smc_manual_port_label'.i18n,
	hintText: 'smc_manual_port_hint'.i18n,
	border: const OutlineInputBorder(),
	isDense: true,
	enabled: loaded.value && !saving.value,
	),
	),
	child: TextField(
	controller: controller,
	enabled: loaded.value && !saving.value,
	keyboardType: const TextInputType.numberWithOptions(
	decimal: false,
	signed: false,
	),
	decoration: InputDecoration(
	labelText: 'smc_manual_port_label'.i18n,
	hintText: 'smc_manual_port_hint'.i18n,
	border: const OutlineInputBorder(),
	isDense: true,
	),
	),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/features/share_my_connection/share_my_connection.dart` around lines 1358
- 1371, Update the TextField itself to bind its enabled state to loaded.value &&
!saving.value, and remove the same enabled setting from InputDecoration. Keep
the existing label, hint, border, and input configuration unchanged.