Skip to content

Upgrade dependencies and build environment - #52

Merged
sigabrtz merged 1 commit into
mainfrom
gba/upgrade-dependencies
Sep 25, 2026
Merged

sigabrtz merged 1 commit into
mainfrom
gba/upgrade-dependencies

Conversation

@sigabrtz

Copy link
Copy Markdown
Contributor

No description provided.

@sigabrtz
sigabrtz requested review from mfiebig and a lite review from Copilot September 24, 2026 07:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical bootstrap and test-compilation issues, plus toolchain consistency gaps, remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity · 1 Medium severity

Open (3)
What changed in this PR

Upgrades project dependencies and the build environment, including Nimble, Ruby/Bundler, Xcode, simulator tooling, and CI configuration.

Changes:

  • Migrates Nimble APIs and refreshes Swift/Ruby dependencies.
  • Updates Xcode, simulator, Homebrew, and Ruby toolchain configuration.
  • Adjusts build scripts and Jenkins credential propagation.
File Summary
Tests/​HealthCardAccessTests/​Commands/​HCCExtPerformSecurityOperationTest.swift Updates Nimble matcher APIs.
scripts/​build Simplifies build invocation.
scripts/​bootstrap Updates Bundler setup and dependency installation.
ReleaseNotes.md Documents dependency and environment updates.
project.yml Updates Nimble and package configuration.
Package.swift Upgrades Nimble.
Package.resolved Refreshes Swift package resolutions.
IntegrationTests/​project.yml Updates integration-test dependencies.
IntegrationTests/​CardSimulationTerminalTestCase/​CardSimulationTerminalTestCase.swift Uses the simulator default version.
Gemfile.lock Refreshes Ruby dependencies.
Gemfile Pins Ruby and Mustache versions.
fastlane/​Scanfile Updates simulator destination.
fastlane/​Fastfile Updates Xcode configuration.
devops/​Jenkinsfile Propagates Nexus credentials.
CardSimulationTestKit/​Tests/​CardSimulationLoaderTests/​xml/​URLExtConfigurationFileProcessorTest.swift Migrates Nimble matchers.
CardSimulationTestKit/​Tests/​CardSimulationCardReaderProviderTests/​internal/​TCPClientExtStreamingTest.swift Adapts asynchronous Nimble expectations.
CardSimulationTestKit/​Sources/​CardSimulationLoader/​SimulationManager.swift Updates simulator defaults.
Brewfile Updates the Xcodes Homebrew dependency.
.tool-versions Pins Ruby 4.0.6.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Brewfile
Comment thread scripts/bootstrap

@mfiebig mfiebig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigabrtz
sigabrtz merged commit 4cd6092 into main Sep 25, 2026
1 check passed
@sigabrtz
sigabrtz deleted the gba/upgrade-dependencies branch September 25, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants