Skip to content

Migrated plugin to Built-in Kotlin Gradle Plugin (KGP)#136

Open
drmirk wants to merge 7 commits into
fluttercommunity:mainfrom
drmirk:kgp_migration
Open

Migrated plugin to Built-in Kotlin Gradle Plugin (KGP)#136
drmirk wants to merge 7 commits into
fluttercommunity:mainfrom
drmirk:kgp_migration

Conversation

@drmirk

@drmirk drmirk commented May 30, 2026

Copy link
Copy Markdown

Flutter 3.44 is warning this plugin to migrate to Kotlin Gradle Plugin (KGP).

Comment thread wakelock_plus/CHANGELOG.md Outdated
Comment thread wakelock_plus/pubspec.yaml Outdated
@drmirk drmirk requested a review from diegotori May 30, 2026 21:05
@drmirk

drmirk commented May 31, 2026

Copy link
Copy Markdown
Author

I have reverted the version bump and rolled back the CHANGELOG.md.

@ubxty ubxty mentioned this pull request Jun 8, 2026
@drmirk

drmirk commented Jun 10, 2026

Copy link
Copy Markdown
Author
  • Updated the example to run in 3.38 by conditionally applying KGP only if AGP version is earlier than 9. So, now the example runs in 3.44 too.
  • Removed the unnecessary buildscript, which is fulfilled by builtin.
  • Tests run without error now.

# https://flutter.dev/custom-fonts/#from-packages

assets:
- packages/wakelock_plus/assets/no_sleep.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And straight away I know that there's no pre-commit configuration in this repo or github action enforcing simple code quality checks to catch things like this an the others further up in this file that introduce unexpected changes into pull requests.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like he reverted it.

@richardnpaul if you have suggestions on where we can harden this in terms of non-pertinent changes, then I'll be happy to review a PR that you make towards this effort.

That or if you can point me to where we can make the changes in the workflow to further enforce this, then I'm all ears.

Thanks in advance.

@theweirdbyte

Copy link
Copy Markdown

Thanks for working on this.

My app is already migrated to the Built-in Kotlin setup, but I am still on AGP 8.x and Flutter still reports the KGP warning from wakelock_plus.

Could you please make sure the fix also covers already-migrated apps on AGP 8.x, so the plugin no longer triggers the Flutter KGP warning in that configuration?

Environment:

Flutter 3.44.4
Dart 3.12.2
AGP 8.13.2
Gradle 8.14
Kotlin 2.2.20

@diegotori

Copy link
Copy Markdown
Collaborator

@drmirk thanks for working on this

Please re-sync your changes with main again. I'm looking to finally release this today. Thanks in advance.

@dkati

dkati commented Jul 6, 2026

Copy link
Copy Markdown

any news here?

Comment thread wakelock_plus/pubspec.yaml Outdated
Comment thread wakelock_plus/pubspec.yaml Outdated
@diegotori

Copy link
Copy Markdown
Collaborator

@drmirk please re-sync your branch with main's latest changes. That should fix the Swift Package Manager failures.

Thanks.

@drmirk

drmirk commented Jul 7, 2026

Copy link
Copy Markdown
Author

@diegotori resync done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants