Migrated plugin to Built-in Kotlin Gradle Plugin (KGP)#136
Conversation
|
I have reverted the version bump and rolled back the CHANGELOG.md. |
|
| # https://flutter.dev/custom-fonts/#from-packages | ||
|
|
||
| assets: | ||
| - packages/wakelock_plus/assets/no_sleep.js |
There was a problem hiding this comment.
And straight away I know that there's no pre-commit configuration in this repo or github action enforcing simple code quality checks to catch things like this an the others further up in this file that introduce unexpected changes into pull requests.
There was a problem hiding this comment.
Looks like he reverted it.
@richardnpaul if you have suggestions on where we can harden this in terms of non-pertinent changes, then I'll be happy to review a PR that you make towards this effort.
That or if you can point me to where we can make the changes in the workflow to further enforce this, then I'm all ears.
Thanks in advance.
|
Thanks for working on this. My app is already migrated to the Built-in Kotlin setup, but I am still on AGP 8.x and Flutter still reports the KGP warning from wakelock_plus. Could you please make sure the fix also covers already-migrated apps on AGP 8.x, so the plugin no longer triggers the Flutter KGP warning in that configuration? Environment: Flutter 3.44.4 |
|
@drmirk thanks for working on this Please re-sync your changes with main again. I'm looking to finally release this today. Thanks in advance. |
|
any news here? |
|
@drmirk please re-sync your branch with main's latest changes. That should fix the Swift Package Manager failures. Thanks. |
|
@diegotori resync done |
Flutter 3.44 is warning this plugin to migrate to Kotlin Gradle Plugin (KGP).