fix: resolve Cloud Build invalid argument errors for substitutions - #1929
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the parameter mapping and evaluation logic in scripts/publish.sh and scripts/publish/cloudbuild.yaml to pass boolean flags explicitly. However, during this refactoring, the --branch parameter was accidentally removed from the execution step in cloudbuild.yaml. This omission will break branch-specific releases, and it should be restored using the new evaluation pattern as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Cloud Build substitution errors when running prerelease/force deploys.
Also had to change a GitHub repository setting to make sure the commit message is the PR description. The previous relnotes were lost and are added back here.
Release Notes
relnote: fix: Remove false warning when using Expression in cors option (#1802)
relnote: feat: Add requiresRole developer API for declarative security support and automatic Manifest extraction (#1908)
relnote: Validate literal
timeoutSecondsvalues per v2 trigger type (0-540s for events, 0-3600s for HTTPS/callable, 0-1800s for task queues, 0-7s for identity functions) so misconfigured values fail at function-definition or manifest-extraction time instead of at deploy time. (#1877)relnote: feat: Add requiresAPI function to allow declaring Google Cloud API dependencies in code. (#1900)
relnote: fix(v1): Call onInit for schedule.onRun functions (#1801)
relnote: feat: Add support to declare lifecycle hooks in functions. (#1915)
relnote: fix(cors): Fix issue using Params to set CORS allowed hosts (#1903)
relnote: fix(v2): Fix event data unpacking for auth event triggers (#1923)
relnote: feat: Add "v2/lifecycle" and "lifecycle" import paths for lifecycle hooks (#1926)
relnote: chore: revamp deploy pipeline to be stateless. Changes must now include relnotes
relnote: chore: move the last encrypted keys into Google Cloud Secrets Manager