Skip to content

Test source search param and unknown-field event deserialization#32

Merged
mcnulty-fp merged 2 commits into
feat/open-api-v3.4.2from
copilot/featopen-api-v342
Jul 1, 2026
Merged

Test source search param and unknown-field event deserialization#32
mcnulty-fp merged 2 commits into
feat/open-api-v3.4.2from
copilot/featopen-api-v342

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Extends FingerprintApiTest to cover two additions from OpenAPI v3.4.2: the new source search parameter and tolerant deserialization of event payloads containing unknown fields.

Changes

  • searchEventsMaximumParamsTest: Adds the source parameter (List<SearchEventsSource>, set to EDGE), includes it in the array-param count, asserts it is emitted as a multi query pair, and chains .setSource(...) on the optional params.
  • getEventWithUnknownFieldTest (new): Mirrors getEventTest against mocks/events/get_event_200_with_unknown_field.json, verifying the SDK ignores unknown top-level and nested fields rather than failing.
final List<SearchEventsSource> SOURCE = Arrays.asList(SearchEventsSource.EDGE);
// ...
assertListContainsPairs(queryParams, "source", SOURCE);
// ...
new FingerprintApi.SearchEventsOptionalParams()
    // ...
    .setSource(SOURCE);

Copilot AI changed the title test: cover source search param and unknown-field event deserialization Test source search param and unknown-field event deserialization Jul 1, 2026
Copilot AI requested a review from mcnulty-fp July 1, 2026 15:55
@mcnulty-fp mcnulty-fp changed the base branch from main to feat/open-api-v3.4.2 July 1, 2026 16:01
- Remove unnecessary assertions in `getEventWithUnknownFieldTest`.
  The test is confirming that an unknown field doesn't trigger
  unexpected errors in deserialization.
@mcnulty-fp mcnulty-fp marked this pull request as ready for review July 1, 2026 16:07
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

java-sdk@8.4.0

Minor Changes

  • events: Add device, os, and os_version to Event (ef17f19)
  • events-search: Add source query parameter to filter events by edge (Automation Intelligence) source (ef17f19)
  • events: Add battery_level and battery_low_power_mode to RawDeviceAttributes (ef17f19)
  • events: Add ml_prediction to vpn_methods (ef17f19)
  • events: Add vpn_ml_score to Event (ef17f19)
  • events-search: Document 404 response for searchEvents operation (ef17f19)

@mcnulty-fp mcnulty-fp merged commit 7a48139 into feat/open-api-v3.4.2 Jul 1, 2026
19 checks passed
@mcnulty-fp mcnulty-fp deleted the copilot/featopen-api-v342 branch July 1, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants