chore(ci): update coverage workflow to use coveralls#110
Open
Orkuncakilkaya wants to merge 9 commits into
Open
chore(ci): update coverage workflow to use coveralls#110Orkuncakilkaya wants to merge 9 commits into
Orkuncakilkaya wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s coverage reporting approach by replacing the existing reusable “coverage diff” workflow with an inline workflow that runs tests with coverage and uploads results to Coveralls. It also adds a few Jest specs to increase coverage around the public API surface and SSR/server behavior, and adjusts pnpm workspace configuration.
Changes:
- Replace the reusable coverage-diff workflow with an explicit GitHub Actions job that installs deps, builds, runs
jest --coverage, and uploads to Coveralls. - Add Jest specs validating
public-apiexports, default settings token behavior, and server-platform rejection behavior inFingerprintService. - Update pnpm configuration (workspace allow-build list, add
packageManagerpin) and refresh the lockfile.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/fingerprintjs-pro-angular/src/public-api.spec.ts | Adds a test ensuring public-api exports expected symbols. |
| projects/fingerprintjs-pro-angular/src/lib/tokens/fingerprint-angular-settings-token.spec.ts | Adds a test for the default injection token factory value. |
| projects/fingerprintjs-pro-angular/src/lib/fingerprint.service.server.spec.ts | Adds server-platform tests asserting methods reject when the agent isn’t initialized. |
| projects/fingerprintjs-pro-angular/package.json | Formatting-only change (trailing brace indentation). |
| pnpm-workspace.yaml | Adjusts workspace config and adds allowed build list. |
| pnpm-lock.yaml | Lockfile refresh due to dependency resolution/config changes. |
| package.json | Removes pnpm onlyBuiltDependencies and adds packageManager pin. |
| .github/workflows/coverage-diff.yml | Replaces reusable workflow with inline steps and Coveralls upload. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
pnpm exec changesetto create a changeset. |
Orkuncakilkaya
requested review from
JuroUhlar,
TheUnderScorer and
ilfa
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.