Skip to content

fix: Serialize UnixTimestamp proto values as raw int64 in remote onli… - #6555

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
falloficaruss:fix/remote-online-store-unix-timestamp
Jul 30, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
falloficaruss:fix/remote-online-store-unix-timestamp

Conversation

@falloficaruss

@falloficaruss falloficaruss commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

his PR fixes a bug where UnixTimestamp feature values cause JSON serialization failures when using the remote online store.

Which issue(s) this PR fixes:

Fixes #6492

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@falloficaruss
falloficaruss marked this pull request as ready for review June 28, 2026 06:45
@falloficaruss
falloficaruss requested a review from a team as a code owner June 28, 2026 06:45
@ntkathole
ntkathole force-pushed the fix/remote-online-store-unix-timestamp branch from 6b08228 to cbc45bc Compare July 30, 2026 08:41
@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.40%. Comparing base (6019bd6) to head (cbc45bc).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6555      +/-   ##
==========================================
+ Coverage   46.36%   46.40%   +0.03%     
==========================================
  Files         414      414              
  Lines       50072    50076       +4     
  Branches     7154     7156       +2     
==========================================
+ Hits        23218    23239      +21     
+ Misses      25231    25204      -27     
- Partials     1623     1633      +10     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.71% <100.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
sdk/python/feast/infra/online_stores/remote.py 63.85% <100.00%> (+5.62%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6019bd6...cbc45bc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ne store transport

Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
@ntkathole
ntkathole force-pushed the fix/remote-online-store-unix-timestamp branch from cbc45bc to 64a8294 Compare July 30, 2026 11:12
@ntkathole
ntkathole merged commit 1e7134f into feast-dev:master Jul 30, 2026
1 check passed
@falloficaruss
falloficaruss deleted the fix/remote-online-store-unix-timestamp branch July 31, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote online store materialization fails for UnixTimestamp feature values

3 participants