Conversation
Contributor
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 medium |
| Security | 15 critical |
🟢 Metrics 8 complexity
Metric Results Complexity 8
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
Release preparation for v2.65.2, updating versioning/docs and refining platform detection (notably memory accounting with ZFS ARC adjustments and GPU PCIe-link probing behavior).
Changes:
- Exclude ZFS ARC (and some caches) from reported memory usage on Linux, FreeBSD, NetBSD, and SunOS.
- Adjust GPU PCIe link speed probing to better align with
driverSpecificmode and avoid waking sleeping dGPUs; add related struct layout asserts. - Update/add logos (CachyOS small variants, Turkish) and refresh preset attribution comments; bump release metadata (CMake/CHANGELOG/Debian scripts).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/logo/ascii/t/turkish.txt | Adds new Turkish ASCII logo artwork. |
| src/logo/ascii/t.inc | Registers the new Turkish logo in the “T” logo list. |
| src/logo/ascii/c/cachyos_small.txt | Updates CachyOS small logo artwork and color markers. |
| src/logo/ascii/c/cachyos_old_small.txt | Adds a preserved “old small” CachyOS logo variant. |
| src/logo/ascii/c.inc | Updates CachyOS logo colors and registers CachyOS_old_small. |
| src/detection/memory/memory_sunos.c | Adjusts SunOS memory used calculation to subtract reclaimable ZFS ARC. |
| src/detection/memory/memory_nbsd.c | Subtracts ZFS ARC from NetBSD used memory calculation. |
| src/detection/memory/memory_linux.c | Switches to bounded parsing for /proc/meminfo and subtracts ZFS ARC from used memory on Linux. |
| src/detection/memory/memory_bsd.c | Subtracts buffer cache and ZFS ARC from BSD used memory calculation. |
| src/detection/gpu/gpu.h | Adds compile-time checks for PCIe speed union/struct layout. |
| src/detection/gpu/gpu_windows.c | Gates PCIe GEN/link queries behind driverSpecific to avoid waking GPUs; refactors PCI query helper. |
| src/detection/gpu/gpu_mthreads.c | Populates PCIe link width/gen for Mthreads GPUs when requested. |
| src/detection/gpu/gpu_linux.c | Moves PCIe sysfs probing behind driverSpecific / availability conditions. |
| src/detection/gpu/gpu_intel.c | Changes Intel igcl device enumeration strategy. |
| src/detection/codec/codec_linux.c | Opens DRM render nodes with O_RDWR for VA-API (DRM) probing. |
| src/common/impl/settings.c | Opens SQLite in read-only + SQLITE_OPEN_NOMUTEX mode for settings query helper. |
| presets/examples/13.jsonc | Adds upstream attribution URL to Catnap inspiration comment. |
| presets/examples/14.jsonc | Adds upstream attribution URL to Catnap inspiration comment. |
| presets/examples/15.jsonc | Adds upstream attribution URL to Catnap inspiration comment. |
| presets/examples/16.jsonc | Adds upstream attribution URL to Catnap inspiration comment. |
| debian/publish.sh | Adds a new Ubuntu codename to the publish list. |
| debian/changelog.tpl | Adds a new top changelog stanza (needs version alignment). |
| CMakeLists.txt | Bumps project version to 2.65.2. |
| CHANGELOG.md | Adds 2.65.2 release notes describing the above changes. |
Used logic from FreeBSD
Comment on lines
11
to
+15
| int32_t pagesFree = ffSysctlGetInt("vm.stats.vm.v_free_count", 0) + ffSysctlGetInt("vm.stats.vm.v_inactive_count", 0) + ffSysctlGetInt("vm.stats.vm.v_cache_count", 0); | ||
| int64_t bytesCache = ffSysctlGetInt64("vfs.bufspace", 0); | ||
|
|
||
| ram->bytesUsed = ram->bytesTotal - (uint64_t) pagesFree * instance.state.platform.sysinfo.pageSize; | ||
| ram->bytesUsed = ram->bytesTotal - (uint64_t) pagesFree * instance.state.platform.sysinfo.pageSize - (uint64_t) bytesCache; | ||
|
|
Comment on lines
156
to
158
| if (outDeviceIds->VendorID != -1u) { | ||
| *outDeviceIds = entry->deviceIds; | ||
| } |
Comment on lines
+1
to
+5
| fastfetch (2.65.1~#UBUNTU_CODENAME#) #UBUNTU_CODENAME#; urgency=medium | ||
|
|
||
| * Update to 2.65.1 | ||
|
|
||
| -- Carter Li <zhangsongcui@live.cn> Wed, 24 Jun 2026 14:21:06 +0800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist