fix(ci): move stream_frame ordering note out of the components block scalar - #750
Merged
Conversation
…scalar
The upload_components.yml components list is a YAML literal block scalar
(components: |), so lines starting with # inside it are literal text, not
comments — the upload-components-ci-action would receive the four-line
"stream_frame is intentionally listed..." note as bogus component directory
paths. This violates the file own rule ("comments are not allowed in the
components list"). Move the explanation up into the # Note: block above the
scalar (next to the ethernet and magnetic_encoder ordering notes) and drop the
comment lines from inside the list. Component ordering is unchanged:
stream_frame still precedes its first-time dependents coredump / dispatcher / ota.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward YAML correctness fix that preserves component ordering while ensuring the scalar contains only valid component paths.
Pull request overview
This PR fixes a CI/workflow YAML correctness issue in upload_components.yml by relocating an ordering explanation out of the components: | literal block scalar, where #-prefixed lines are treated as literal content (not comments) and can be misinterpreted as component paths.
Changes:
- Moved the
stream_frameordering rationale into the comment block above thecomponents: |scalar. - Removed the
# stream_frame ...lines from inside the literal block scalar to ensure only validcomponents/...paths are passed to the upload action.
File summaries
| File | Description |
|---|---|
| .github/workflows/upload_components.yml | Moves the stream_frame ordering note above the `components: |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
componentslist inupload_components.ymlis a YAML literal block scalar (components: |), so lines beginning with#inside it are literal text, not comments. The four-linestream_frame is intentionally listed…note added in #747 therefore gets handed toupload-components-ci-actionas bogus component directory paths — which is exactly what the file’s own rule forbids:Fix
# Note:block above the scalar, alongside the existingethernetandmagnetic_encoderordering notes.Component ordering is unchanged —
stream_framestill precedes its first-time dependentscoredump/dispatcher/ota.Verified the block scalar now contains 140 entries, all
components/…paths, zero#lines.🤖 Generated with Claude Code