GameState: Set scene when not persisting progress#2544
Merged
Conversation
When progress is not persisted, that is when the game runs from a specific scene that is not the main one, GameState.scene should be set to a new PerSceneState resource. Otherwise the game may fail to access its properties like lights_on. Fix #2543
manuq
marked this pull request as ready for review
July 14, 2026 16:02
|
Play this branch at https://play.threadbare.game/branches/endlessm/fix-lights-on/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
felixwalberg
approved these changes
Jul 14, 2026
felixwalberg
left a comment
felixwalberg
left a comment
Contributor
There was a problem hiding this comment.
This makes sense. Otherwise, the game would have no current scene and no way to reference information related to it, as you mentioned.
alcole2
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When progress is not persisted, that is when the game runs from a specific scene that is not the main one, GameState.scene should be set to a new PerSceneState resource. Otherwise the game may fail to access its properties like lights_on.
Fix #2543