Import LoreJam Team 13's project from Backstitch#2480
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/lorejam-team-13/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
Playing from the branch and using the debug menu to mark all previous lore quests as completed, I couldn't pass the house. It looks like this is because of our recent teleport changes: 
|
|
I'm asking for their GitHub usernames, for now I asked this on Discord:
|
|
@GianPierooo and @xXLeopoldoXx expressed their preference to submit a LoreQuest. |
This is manually rebased onto current main. I discarded some changes that are not intended, but there is more to discard!
Update the quest to suit the Teleporter refactor in #2238 . Fix it by intantiating the teleporter.tscn.
Since this scene is a test and not part of the quest, is easier to remove it entirely than to make it work. Issues were: - It was using the now removed frame camera behavior. - The teleporter stopped working after refactor.
The abilities is now part of GameState.player. Also apply the pre-commit linter changes in the scripts. For the next_scene in ability_exit.gd I had to convert the scene path to its UID, because it exceeded the max length. By the way this script should be soon changed: is checking if the powerup for the new ability was grabbed inside a body-entered callback, and is using SceneSwitcher directly instead of a SceneLink or Teleporter.
Update to the refactor in #2302 . Previously each powerup had the name. Now the name is for lore quests in lore_info.gd. Also add a TODO note for changing this to be a modifier of repel. Commit the editor changes of the tscn file that contains the powerup.
|
I have rebased with latest main and appended commits to make the quest work again. Because we introduced some regressions (like #2480 (comment)) due to refactors which I consider "our fault":
@GianPierooo and @xXLeopoldoXx please start by:
The way you should work (for now) is by starting from this branch lorejam-team-13 and opening pull requests against it (not main). Try to do one pull request per change. Once we consider that this branch is suitable for merging with main, you'll be able to continue upstream! |
2 participants
This is https://github.com/wjt/threadbare-lorejam-mythical-meadows/tree/equipo-13 manually rebased onto current main. I discarded some changes that are not intended, but there is more to discard!