fix: support extension schema URI containers in path-less PATCH#207
Open
q-uint wants to merge 2 commits into
Open
fix: support extension schema URI containers in path-less PATCH#207q-uint wants to merge 2 commits into
q-uint wants to merge 2 commits into
Conversation
A PATCH add/replace without a "path" whose value nests extension attributes under their schema URI (RFC 7643 Section 3.3, RFC 7644 Section 3.5.2) failed with "invalid uri prefix". validateEmptyPath ran the URI key through ParsePath, which strips the trailing segment and produces a URI that never matches a registered schema. Detect keys that exactly match a known schema URI and validate their members against that schema instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PATCH add/replace without a "path" whose value nests extension attributes under their schema URI (RFC 7643 Section 3.3, RFC 7644 Section 3.5.2) failed with "invalid uri prefix". validateEmptyPath ran the URI key through ParsePath, which strips the trailing segment and produces a URI that never matches a registered schema.
Detect keys that exactly match a known schema URI and validate their members against that schema instead.
Fixes #204