Use flatpak preinstall for system Flatpak apps - #364
Merged
Conversation
11 tasks
Improted from jumpyvi/elementary-atomic-os@f46b834 Co-Authored-By: JumpyVi <62212220+jumpyvi@users.noreply.github.com>
Make sure to match the path with elementary-atomic-os: https://github.com/jumpyvi/elementary-atomic-os/blob/00571ee5e2cc0c9f4ec53f7c810074e04b5e6061/mkosi.extra/usr/share/flatpak/preinstall.d/appcenter.preinstall
Previously this was done in the postinst script of each dummy Debian packages. Since they're all gone, now this needs to be done explicitly.
Member
Author
|
The build error of "CI / build (development-target) (pull_request)" will be fixed in #367. |
ryonakano
marked this pull request as ready for review
August 13, 2026 02:59
ryonakano
commented
Aug 13, 2026
danirabbit
requested changes
Aug 13, 2026
Since there are no plan to ship apps from other remotes by default, this is just overkilling.
ryonakano
marked this pull request as draft
August 13, 2026 03:43
ryonakano
marked this pull request as ready for review
August 13, 2026 06:56
danirabbit
approved these changes
Aug 13, 2026
Member
Author
|
Let's go 🚀 |
ryonakano
enabled auto-merge (squash)
August 14, 2026 01:24
ryonakano
disabled auto-merge
August 14, 2026 01:25
Member
Author
Oh I need to update the workflow file too in addition to the deb-packaging 😞 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of elementary/os#783
See #367 for what I tested.
Changes summary
flatpak preinstallon startup (thanks to @jumpyvi)