Adapt OAuth2 implementation to Matrix Spec v1.18#34026
Open
t3chguy wants to merge 17 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…o t3chguy/oauth # Conflicts: # apps/web/src/contexts/SDKContext.ts # apps/web/test/unit-tests/components/structures/MatrixChat-test.tsx # apps/web/test/unit-tests/components/views/settings/tabs/user/SessionManagerTab-test.tsx # apps/web/test/unit-tests/contexts/SdkContext-test.ts
florianduros
approved these changes
Jul 3, 2026
|
|
||
| const cli = useMatrixClientContext(); | ||
| const sdkContext = useContext(SDKContext); | ||
| const cli = sdkContext.client!; |
Member
There was a problem hiding this comment.
A reason to not use anymore the matrix client hook? To avoid circular import?
Member
Author
There was a problem hiding this comment.
Just no point using two contexts when one provides both values, MatrixClientContext is such that it claims you always have a client but it can actually return null so this is no less safe.
…o t3chguy/oauth # Conflicts: # apps/web/src/Lifecycle.ts # apps/web/src/MatrixClientPeg.ts # apps/web/test/unit-tests/Lifecycle-test.ts # apps/web/test/unit-tests/MatrixClientPeg-test.ts # apps/web/test/unit-tests/components/structures/MatrixChat-test.tsx
…o t3chguy/oauth # Conflicts: # apps/web/src/IConfigOptions.ts # apps/web/src/Lifecycle.test.ts # apps/web/src/Lifecycle.ts # apps/web/src/components/views/spaces/SpacePanel.tsx # apps/web/src/contexts/SDKContextClass.ts # apps/web/src/vector/app.test.ts # apps/web/src/viewmodels/menus/UserMenuViewModel.ts # apps/web/test/unit-tests/components/structures/MatrixChat-test.tsx # apps/web/test/unit-tests/components/views/settings/tabs/user/AccountUserSettingsTab-test.tsx # apps/web/test/unit-tests/components/views/settings/tabs/user/SessionManagerTab-test.tsx # apps/web/test/viewmodels/menus/UserMenuViewModel-test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#5390
Fixes Fixes #32617