feat(factory): add --yes confirmation guard for destructive commands - #537

Draft

margaretjgu wants to merge 23 commits into

mainfrom

fix/destructive-confirmation-guard

Commits on Aug 14, 2026

fix: infer destructive intent for cloud DELETE and known destructive endpoints
margaretjgu
committed
6bfd24d
fix: mark extension remove as destructive
margaretjgu
committed
e3951f8
feat: add --yes confirmation guard for destructive commands
margaretjgu
committed
5f1480c
chore: regenerate cli schema with --yes flag
margaretjgu
committed
c794af5
fix: use schema destructive flag for cloud commands
margaretjgu
committed
cdc3e10
fix: lowercase yes flag help text
margaretjgu
committed
f113cbd
test: add cloud destructive intent guard tests
margaretjgu
committed
de1821e
chore: regenerate cli schema
margaretjgu
committed
952aad0
fix: pass yes flag in generated es delete tests
margaretjgu
committed
1412438
fix: pass yes flag in kb functional delete calls
margaretjgu
committed
606437a
ci: cap test node job at 10 minutes
margaretjgu
committed
bcbadf6
test: fail individual tests after 20s not the job
margaretjgu
committed
89b9267
test: drop dynamic import causing windows test hang
margaretjgu
committed
08eb210
test: raise per test timeout to 60s
margaretjgu
committed
3a4fc4b
test: drop coverage flags to isolate windows hang
margaretjgu
committed
af9e1f7
test: rename confirmation test to check position dependence
margaretjgu
committed
2879832
test: revert to dynamic commander import, restore filename
margaretjgu
committed
cc35e86
test: merge tty prompt cases back into one test
margaretjgu
committed
b27b223
test: add diagnostic marker for real readline fallback
margaretjgu
committed
b8d0380
test: revert failed hang fixes, keep timeout diagnostics
margaretjgu
committed
a873792
test: add isolated tty hang repro file
margaretjgu
committed
cf5d16a
fix: stop mutating process.stderr.isTTY directly in tests
margaretjgu
committed
5cb43ae
test: add diagnostics to isolate windows hang
margaretjgu
committed
9238e13

Navigation Menu

Uh oh!

feat(factory): add --yes confirmation guard for destructive commands - #537

feat(factory): add --yes confirmation guard for destructive commands#537
margaretjgu wants to merge 23 commits into
mainfrom
fix/destructive-confirmation-guard

Commits on Aug 14, 2026

fix: infer destructive intent for cloud DELETE and known destructive endpoints

fix: mark extension remove as destructive

feat: add --yes confirmation guard for destructive commands

chore: regenerate cli schema with --yes flag

fix: use schema destructive flag for cloud commands

fix: lowercase yes flag help text

test: add cloud destructive intent guard tests

chore: regenerate cli schema

fix: pass yes flag in generated es delete tests

fix: pass yes flag in kb functional delete calls

ci: cap test node job at 10 minutes

test: fail individual tests after 20s not the job

test: drop dynamic import causing windows test hang

test: raise per test timeout to 60s

test: drop coverage flags to isolate windows hang

test: rename confirmation test to check position dependence

test: revert to dynamic commander import, restore filename

test: merge tty prompt cases back into one test

test: add diagnostic marker for real readline fallback

test: revert failed hang fixes, keep timeout diagnostics

test: add isolated tty hang repro file

fix: stop mutating process.stderr.isTTY directly in tests

test: add diagnostics to isolate windows hang