fix: lazy initialize ImageRegistry

[trancexpress]

This change adjusts TMUIPlugin.start() to not initialize the ImageRegistry, avoiding start-up exceptions when TMUIPlugin.start() is not called from a UI thread.

Instead, the ImageRegistry is initialized lazily by overriding: AbstractUIPlugin.initializeImageRegistry()

Fixes: #1010

[Copilot]

Pull request overview

This PR updates TMUIPlugin.start() to avoid SWTError: Invalid thread access by deferring image-registry initialization to the UI thread when the Eclipse workbench is running (addressing issue #1010 seen in headless/LSP test scenarios).

Changes:

• Replace direct image initialization in TMUIPlugin.start() with a dedicated initializeImages() helper.
• Schedule TMImages initialization via an Eclipse UIJob when PlatformUI.isWorkbenchRunning() is true.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[sebthom]

@akurtakov do you think a more idomatic solution would be to not initialize the image registry in the start method or async via UIJob but lazy like this?

 @Override
 protected void initializeImageRegistry(final ImageRegistry registry) {
      TMImages.initalize(registry);
  }

[sebthom]

@akurtakov ping :-)

[akurtakov]

@sebthom Sorry, this one got lost in the amount of notifications.
Your suggestion should be the way to go IMO, that should solve the problem as createImageRegistry already falls back to Display.getCurrent if platform is not running https://github.com/eclipse-platform/eclipse.platform.ui/blob/a217bfc2419673f6547fb67f0970cbf91bdf2192/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/plugin/AbstractUIPlugin.java#L160 .

[sebthom]

Thanks!

[trancexpress]

Thank you for merging!