coverage: adoption fixes from first consumers - #436
Merged
Conversation
Three issues surfaced by early adopters of the coverage module (persistency #380, inc_someip_gateway #256): - generate_coverage_html: --yaml is now OPTIONAL. Without it, justification processing is skipped and the COVERAGE_THRESHOLD gate applies to the raw line coverage computed from the LCOV data (NOT llvm-cov's text TOTAL, which omits baseline-only files and would let untested files escape the gate). Previously the script hard-errored before extracting any HTML, which read as 'no report is generated' for repos without a justification YAML. - generate_coverage_html: new --archive-dir <dir> assembles the artifacts tree without zipping it. Preferred for CI uploads: actions/upload-artifact zips its input itself, so uploading the --archive zip nested it in a second zip. - README: document both changes, plus the requirement that the coverage bazelrc import must precede a user.bazelrc try-import (bazelrc is last-wins; the local-override file must stay last). Integration test extended: no-yaml mode (HTML produced, raw gate enforced at high/low thresholds) and --archive-dir content checks.
Coverage ReportCoverage report was generated. Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run). Overall coverage rate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues surfaced by early adopters of the coverage module (persistency #380, inc_someip_gateway #256):
Integration test extended: no-yaml mode (HTML produced, raw gate enforced at high/low thresholds) and --archive-dir content checks.