test: missing attribute tests - #848
Merged
AlexanderLanin merged 1 commit intoSep 22, 2026
Merged
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
September 22, 2026 12:57
Contributor
|
Documentation preview for this pull request is available at: |
| Tests that a versioning attribute is mandatory for all needs and that it | ||
| accepts whole numbers. | ||
|
|
||
| Partial because "rejects non-whole numbers" cannot be tested with this rst-file approach. |
Contributor
There was a problem hiding this comment.
Really? Would this not be a metamodel error if it's non whole number? Cause the regex?
Contributor
Author
There was a problem hiding this comment.
The problem is that this is not a metamodel warning but a sphinx-needs warning. Example:
requirements.rst:205: WARNING: Need could not be created: Field 'version' is invalid: Cannot convert '1.3' to integer [needs.create_need]
AlexanderLanin
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Improving tool qualification.
🚨 Impact Analysis
✅ Checklist