Stop using ant-contrib#3395
Merged
Merged
Conversation
Contributor
HannesWell
reviewed
Jun 20, 2026
HannesWell
left a comment
HannesWell
left a comment
Member
There was a problem hiding this comment.
That's awesome. Thanks for this!
I believe to vaguely remember that I've seen these attributes before but didn't make it work back then. But this makes the build noticeably simpler and avoids a dependency on a dependency last released over 15 years ago.
I just have three minor points below.
akurtakov
force-pushed
the
treebin
branch
2 times, most recently
from
ede8fdb to
9b3c3a6
Compare
Member
Author
|
I truly don't understand the new issues but they are totally not related to this change. |
HannesWell
approved these changes
Jun 20, 2026
Member
There was a problem hiding this comment.
Thanks again for this.
I truly don't understand the new issues but they are totally not related to this change.
Maybe something changed in ECJ?
But I cannot reproduce it in the IDE, so maybe it's just something in the build. I don't think it's related.
Ant 1.9.1 added https://ant.apache.org/manual/ifunless.html which is the sole reason why ant-contrib was used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ant 1.9.1 added https://ant.apache.org/manual/ifunless.html which is the sole reason why ant-contrib was used.