Skip to content

fix(ci): migrate macOS x64 release runner to macos-26-intel - #233

Merged
dwgx merged 1 commit into
dwgx:masterfrom
andya1lan:fix/macos-26-intel-runner
Jul 30, 2026
Merged

fix(ci): migrate macOS x64 release runner to macos-26-intel#233
dwgx merged 1 commit into
dwgx:masterfrom
andya1lan:fix/macos-26-intel-runner

Conversation

@andya1lan

Copy link
Copy Markdown
Contributor

改了什么 / What changed

  • Replace the retired macos-13 runner used by the macOS x64 release job with macos-26-intel.
  • Update the related comments while preserving the existing non-blocking x64 release behavior.

为什么 / Why

GitHub shut down the macOS 13 runner image on December 4, 2025:
https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

macos-26-intel is the current supported macOS 26 x64 runner label:
https://github.com/actions/runner-images#available-images

测试 / Testing

  • Parsed .github/workflows/release.yml successfully with Ruby YAML.
  • git diff --check passes.
  • No application tests were run because this only changes the GitHub Actions runner image.

Checklist

  • 代码风格和现有文件一致 / Code style matches existing files
  • 没有引入 npm 依赖 / No new npm dependencies
  • 不涉及 LS binary 协议 / LS binary protocol not affected
  • 不涉及 dashboard UI / Dashboard UI not affected

Copilot AI review requested due to automatic review settings July 29, 2026 12:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions release workflow to keep the non-blocking macOS x64 build running on a supported Intel runner image, after the retirement of macos-13.

Changes:

  • Switch the macOS x64 release job runner from macos-13 to macos-26-intel.
  • Update surrounding workflow comments/step labels to reflect the new runner choice while preserving the existing non-blocking behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dwgx
dwgx merged commit 7c39896 into dwgx:master Jul 30, 2026
5 checks passed
dwgx added a commit that referenced this pull request Jul 30, 2026
#232 按账号隔离上游模型目录:方案取舍是最值钱的部分(并集发现 + 账号维度路由),
两轮修复精准命中,并主动做了 Dashboard fail-open 告警与 out-of-scope 划分。
未到 S 是因为初版漏了两个 fail-open 场景且一度有条不实的测试声明。

#233 四行 CI 改动,价值全在诊断 —— 它替我们发现了自己连漏四个版本的
macOS x64 构建缺口(终态是 cancelled 而非排队,而我们四次都判断成不用管)。
dwgx added a commit that referenced this pull request Jul 30, 2026
合并 #232(按账号隔离上游模型目录)与 #233(CI x64 runner),外加检索端点的
5 条契约修复 —— 其中 2 条是 v3.9.4 自己引入的,含一条把 PII 写进 URL。

两条教训记入交接文档:
- 读过某条约束不等于会遵守它。那条 PII 缺陷里,我两小时前才引用过
  caller-key.js 的 PII 注释,然后亲手违反了它。
- 注释解释的是设计意图、不是当前事实。macOS x64 连续四个版本终态是 cancelled
  而非排队,我每次照 workflow 注释解释就放过了,是外部贡献者发现的。

#234 已验证成立,进未修清单。测试 3072 → 3108,全量绿。
@dwgx

dwgx commented Jul 30, 2026

Copy link
Copy Markdown
Owner

已合并 ✅ — v3.9.5

这条修的是我们自己的问题,而且我判断错了四次。

你指出 macos-13 已下线之后我去核实了终态:

v3.9.1 -> cancelled
v3.9.2 -> cancelled
v3.9.3 -> cancelled
v3.9.4 -> cancelled

全部是 cancelled,不是排队。 也就是连续四个版本都没有 macOS x64 二进制发出去。而我这边每次看到 GitHub UI 上的 queued,就照 workflow 里那条"x64 可能排几小时"的注释解释过去了,四次都判断成"非阻塞、不用管",从没查终态。

教训我记进交接文档了:注释解释的是设计意图,不是当前事实;判断某个 job "没问题"必须看终态。

核实过的依据:

  • release.yml:151 确为 macos-13
  • actions/runner-images README 确认 macos-26-intel 是当前 macOS 26 x64 标签
  • 保留了 x64 不进 release needs 的非阻塞语义 ✅

台账:weight B+。四行改动,但价值全在诊断 —— 它纠正的是一个已经影响四个已发布版本的事实,而且是外部贡献者替维护方发现自身发布链缺口。这一条对标 lovivi #204 那种"十行精准方言修复"同档但更靠上。

谢谢,这个盯得比我细。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants