Repository navigation
Add CPM popup logic - #9446
Add CPM popup logic#9446CrisBarreiro wants to merge 2 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
|
|
||
| fun onConfirmClicked() { | ||
| viewModelScope.launch { command.send(Command.Close) } | ||
| } |
There was a problem hiding this comment.
Confirm ignores selected option
High Severity
onConfirmClicked only emits Close and never applies the selected choice via autoconsent. The copy offers enabling protection / accepting non-rejectable cookies (MAX) vs leaving things unchanged (KEEP_CURRENT), so Confirm currently discards the choice and leaves settings untouched.
Please tell me if this was useful or not with a 👍 or 👎.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
| applicationContext.startActivity(intent, options) | ||
| } | ||
|
|
||
| return@withContext ModalEvaluator.EvaluationResult.ModalShown |
There was a problem hiding this comment.
Prompt can reappear forever
High Severity
evaluate returns ModalShown whenever cookiePopUpOptInPrompt is enabled, with no local already-shown / dismissed gate. Peer modal evaluators persist eligibility after display. While the toggle stays on, this prompt can resurface after each coordinator cooldown and keep claiming the modal slot.
Please tell me if this was useful or not with a 👍 or 👎.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
4230730 to
adfd13b
Compare
1 participant
Task/Issue URL:
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Feature 1
UI changes
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Medium Risk
New modal can interrupt browsing when the toggle is on, and confirm does not yet apply cookie-popup settings—product behavior may be incomplete until follow-up logic lands.
Overview
Adds a Cookie Pop-up Protection opt-in flow gated by a new
cookiePopUpOptInPromptremote toggle (default INTERNAL). When enabled,CookiePopupOptInEvaluatorregisters with the prompts coordinator (ModalEvaluator, priority 6), delays briefly, and launches a translucent bottom-sheetCookiePopupOptInActivitywith slide animations.The sheet uses onboarding-themed UI: two selectable options, copy that switches between protection on vs off variants based on
Autoconsent.isSettingEnabled(), and confirm handling that only closes the activity today (no persistence of the selected choice in this diff).Supporting changes:
prompts-coordinator-apidependency; settings header swapscookie_popups_check_128forcookie_popups_check_96; onboardingInputTypebackground now references the sharedCommonRdrawable.Reviewed by Cursor Bugbot for commit adfd13b. Bugbot is set up for automated code reviews on this repo. Configure here.