Improve revs and restore commands, clarify restore help#244
Merged
Conversation
- revs: use commandOutput/filesNewFunc for testability, add --time and --time-format flags for consistent formatting with ls and search - restore: clarify help text (addresses #109), explaining that target-path is where the restored file is saved; add verbose output showing revision and server-modified time - Add tests for both commands using mock infrastructure Closes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandOutput/filesNewFuncfor testability, added--timeand--time-formatflags for consistent formatting withlsandsearch<target-path>is where the restored file is saved, added verbose output with revision and server-modified timeCloses #109
Test plan
dbxcli revs /pathlists revision IDsdbxcli revs -l --time-format=rfc3339 /pathshows absolute timestampsdbxcli restore --helpclearly explains target-path and revisiondbxcli restore -v /path revprints confirmation with revision infogo test ./...)