Migrate search from deprecated Search to SearchV2 API#243
Merged
Conversation
The Dropbox Search endpoint is deprecated in favor of SearchV2. This migration adds cursor-based pagination (fetches all results instead of being limited to 100), uses SearchOptions for path scoping, and routes output through commandOutput for testability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Searchendpoint withSearchV2which supports cursor-based paginationSearchOptions.Pathinstead of positionalSearchArgfieldcommandOutputfor testabilitySearchV2andSearchContinueV2in test infrastructureTest plan
dbxcli search "query"returns results using SearchV2dbxcli search "query" /pathscopes search correctlydbxcli search -l "query"shows long format with revision/size/timego test ./...)