Repository navigation
test: cover OIDC callback login persistence - #259
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a component regression test for the OIDC callback behavior fixed in #258. The test verifies that a successful callback dispatches
login/changeLoginStatuswith the server response before redirecting to the home page, preventing the token persistence regression reported in #257.Updates the Umi 4 frontend unit-test setup to use Jest with
@umijs/test, since the previousmax testcommand is no longer registered.User-facing changes
None. This adds regression coverage and restores the frontend unit-test command.
Release notes
Maintainers: apply the most appropriate release label before merging. Use
skip-release-notesonly when this pull request should not appear in a release.breaking-changeenhancementorfeaturebugorfixperformancesecuritydependencies,build, orcidocumentationRecommended label:
skip-release-notes.Verification
npm test -- --runInBand(4 tests passed)npm run tsc