Fix SQL Server password in copilot-setup-steps.yml#38445
Merged
Conversation
… in password Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
June 17, 2026 21:36
View session
AndriySvyryd
changed the title
Login failed for user 'SA' in copilot-setup-steps by escaping $$ in SQL Server passwordThere was a problem hiding this comment.
Pull request overview
Fixes the SQL Server test connection string export in the Copilot agent setup workflow so the SA password containing $$ is written correctly to $GITHUB_ENV (avoiding bash $$ PID expansion), restoring successful SQL Server authentication in CI/agent sessions.
Changes:
- Escape
$$as\$\$when echoingTest__SqlServer__DefaultConnectioninto$GITHUB_ENV.
wtgodbe
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL Server connection string in
copilot-setup-steps.ymlis written to$GITHUB_ENVvia a double-quoted bashecho. Bash expands$$(the SA password contains$$) to the shell's PID, so the env-var password no longer matches the container's literalSA_PASSWORD, causingLogin failed for user 'SA'in tests.Change
$$→\$\$) in theechowritingTest__SqlServer__DefaultConnection, so bash emits a literal$$that matches the SA password set in the serviceenv:block (which GitHub Actions does not run through a shell).